Skip to content

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Sep 27, 2016

Big optimisation of all svg with svgo

Stats:
Old size: 177.536Ko
New size: 101.352Ko
Size reduced by: 44,49%

Not sure if really necessary. Did it in 30sec.

find -name "*.svg" -exec svgo {} \;

Only the /core/img/desktopapp.svg is not worth optimising.

@skjnldsv skjnldsv added the 3. to review Waiting for reviews label Sep 27, 2016
@skjnldsv skjnldsv self-assigned this Sep 27, 2016
@mention-bot
Copy link

@skjnldsv, thanks for your PR! By analyzing the annotation information on this pull request, we identified @blizzz, @paurisa, @rullzer and @Xenopathic to be potential reviewers

@nickvergessen
Copy link
Member

Same here, to make tests pass, see #1535 (comment)

Signed-off-by: John Molakvoæ <fremulon@protonmail.com>
@skjnldsv
Copy link
Member Author

@nickvergessen Rebased with signature :)

@MorrisJobke
Copy link
Member

I tested this especially with Firefox because there we had the biggest problems with SVGs. Works fine 👍

@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Sep 28, 2016
@LukasReschke
Copy link
Member

Clicked around in Safari and all seemed fine 👍

@jancborchardt
Copy link
Member

@skjnldsv this caused big issues with lots of source files: #4076 it would be good if we can revert that and use Scour instead of Svgo, as we did so far without issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants