Skip to content

Conversation

@skjnldsv
Copy link
Member

Good:
kazam_screencast_00004

Bad:
kazam_screencast_00003

@skjnldsv skjnldsv added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: files labels Sep 27, 2016
@skjnldsv skjnldsv self-assigned this Sep 27, 2016
@nickvergessen
Copy link
Member

You need to commit using commit -s, so it adds your signature:
https://github.com/nextcloud/server/blob/master/CONTRIBUTING.md#sign-your-work

You can also amend the signature manually afterwards:
git commit --amend and then add the line:
Signed-off-by: Random J Developer <random@developer.example.org>

on a new line at the end of your commit message.

@nickvergessen
Copy link
Member

👍 for the change

@nickvergessen nickvergessen added this to the Nextcloud 11.0 milestone Sep 27, 2016
@nickvergessen nickvergessen mentioned this pull request Sep 27, 2016
Signed-off-by: John Molakvoæ <fremulon@protonmail.com>
@skjnldsv skjnldsv force-pushed the files-loading-css-fix branch from e2f9877 to f623d02 Compare September 27, 2016 19:06
@juliusknorr
Copy link
Member

👍

@juliusknorr juliusknorr merged commit f219ed2 into master Sep 28, 2016
@juliusknorr juliusknorr deleted the files-loading-css-fix branch September 28, 2016 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. feature: files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants