Try to delete the cypress folder of the viewer app

[MorrisJobke]

Fixes #16229

[MorrisJobke]

As proposed by @jospoortvliet

[MorrisJobke]

/backport to stable16

[MorrisJobke]

I tested this on Nextcloud 16.0.2 and ran the occ maintenance:repair manually (which is triggered during the upgrade as well) and it worked.

[nickvergessen]

Can't we get it from the app manager? in case it was moved?

[MorrisJobke]

I do a file_exists anyways and it should only matter if the app was installed via the release package and not updated via appstore. So this is just the easiest way without the problem of dealing with multiple app directories.

[kesselb]

I would prefer RemoveCypressFiles

[kesselb]

server/lib/private/Repair/NC16/CleanupCardDAVPhotoCache.php

Lines 91 to 103 in 11a27b2

	private function shouldRun(): bool {
	return version_compare(
	$this->config->getSystemValue('version', '0.0.0.0'),
	'16.0.0.0',
	'<='
	);
	}
	public function run(IOutput $output): void {
	if ($this->shouldRun()) {
	$this->repair($output);
	}
	}

I guess you want to release it today? You could add something like this if there is some time left.

[MorrisJobke]

It was there and the check for the actual outcome is far better IMO than the "lets assume some version number and check for that". And here the check for the outcome was pretty straight forward so I reduced the code to be better readable by just put it where it is checked.

[kesselb]

I'm okay with that. Would it make sense to mark this as deprecated to remove it in the future?

[MorrisJobke]

Let me add this.

[MorrisJobke]

In general that was also the idea of putting those repair steps in the NC16 folder for example. Because you know when they were added.

[MorrisJobke]

I also did some cleanup in #16292

[juliusknorr]

I think this should actually not be required. From a look at the updater code it seems that it only deletes files from apps listed in shipped.json.
https://github.com/nextcloud/updater/blob/master/lib/Updater.php#L787-L796

For viewer that was not the case in 16.0.1 which is why the update to 16.0.2 doesn't delete those files. (See https://github.com/nextcloud/server/pull/15592/files)

This means that if you have installed the RC of 16.0.2 and update to 16.0.2 the error will be gone, which might explain that some of us could not reproduce the issue with the release.

But I'm also fine to have this in, just to be sure 😉

[juliusknorr]

Makes of course still sense to have this cleanup job, in case someone goes from 16.0.1 to 16.0.3 then 👍

[MorrisJobke]

For viewer that was not the case in 16.0.1 which is why the update to 16.0.2 doesn't delete those files. (See https://github.com/nextcloud/server/pull/15592/files)

This means that if you have installed the RC of 16.0.2 and update to 16.0.2 the error will be gone, which might explain that some of us could not reproduce the issue with the release.

The argument by @jospoortvliet was that we should try to fix this proactive instead of assuming that it will resolve in the future by itself. ;) And as this is straight forward I'm fine with the proactive repair step.

[MorrisJobke]

I would prefer RemoveCypressFiles

Done ✅

[jospoortvliet]

thanks, good work 👍

[backportbot-nextcloud]

backport to stable16 in #16297