Remove one time repair steps that have already run when updating to 17 #16292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
requested review from
ChristophWurst,
icewind1991,
juliusknorr,
kesselb,
rullzer and
skjnldsv
Member
|
I find it is confusing that we had previous repair steps but we cannot find them afterwise. Won't that be harder to narrow if something goes wrong? |
Member
Author
Why should we. They cleaned up the broken behavior already and then it's basically dead code. We also don't keep buggy code just because it caused some state that we have now. Or did I miss something here or got you completely wrong? And in case: it's all within git. So it's not really gone. |
Member
|
Well, yes it make sense :) |
skjnldsv
approved these changes
Jul 8, 2019
juliusknorr
approved these changes
Jul 8, 2019
juliusknorr
added
4. to release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just got aware of this again after a discussion with @kesselb in #16288 (comment)