Allow to overwrite share target mountpoints #19321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
force-pushed
the
enh/allow-to-overwrite-share-target-mountpoints
branch
from
9b24450 to
e822695
Compare
2 tasks
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
enh/allow-to-overwrite-share-target-mountpoints
branch
from
e822695 to
841f2f3
Compare
Member
Author
|
Would be nice to get this in, so we can finish the Talk side of this feature. |
nickvergessen
added
3. to review
ChristophWurst
approved these changes
Feb 21, 2020
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
Not the most appropriate use of events, but fine by me
juliusknorr
approved these changes
Feb 26, 2020
rullzer
requested changes
Feb 27, 2020
| * @since 19.0.0 | ||
| */ | ||
| public function __construct(IShare $share, | ||
| View $view, |
Member
There was a problem hiding this comment.
any reason not to just use the node API here?
Member
Author
There was a problem hiding this comment.
In https://github.com/nextcloud/server/pull/19321/files#diff-815375797d10aaf371d625ead4ed15beR93 we don't have the nodes api available and I wanted to keep the impact minimal (remember, we are inside the process of setting up the FS for the user)
Member
There was a problem hiding this comment.
Right right.
Ok then lets do it.
rullzer
approved these changes
Feb 28, 2020
nickvergessen
deleted the
enh/allow-to-overwrite-share-target-mountpoints
branch
ChristophWurst
added a commit
to nextcloud/documentation
that referenced
this pull request
Apr 10, 2020
Ref nextcloud/server#19845 Ref nextcloud/server#19890 Ref nextcloud/server#19075 Ref nextcloud/server#19670 Ref nextcloud/server#19412 Ref nextcloud/server#14722 Ref nextcloud/server#19746 Ref nextcloud/server#19321 Ref nextcloud/server#19569 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
added a commit
to nextcloud/documentation
that referenced
this pull request
Apr 10, 2020
Ref #1951 Ref nextcloud/server#19845 Ref nextcloud/server#19075 Ref nextcloud/server#14722 Ref nextcloud/server#19321 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for nextcloud/spreed#2876