Add optional comments reference_id #19890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickvergessen
added
enhancement
3. to review
nickvergessen
requested review from
ChristophWurst,
blizzz,
danxuliu and
rullzer
nickvergessen
force-pushed
the
enh/comments-reference-id
branch
from
6bade5f to
0bf13a3
Compare
4 tasks
rullzer
reviewed
Mar 11, 2020
nickvergessen
commented
Mar 11, 2020
| protected function hasMissingColumns(): array { | ||
| $indexInfo = new MissingColumnInformation(); | ||
| // Dispatch event so apps can also hint for pending index updates if needed | ||
| $event = new GenericEvent($indexInfo); |
Member
Author
There was a problem hiding this comment.
For now i copied the indexes code, but we could also go for a new event class here making things proper. i dont care too much
Member
There was a problem hiding this comment.
Depends. If we consider this public then I would go for the new things straight away
ChristophWurst
approved these changes
Mar 31, 2020
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
enh/comments-reference-id
branch
from
15dae1b to
60d9384
Compare
Member
Author
|
Squash time |
nickvergessen
added
4. to release
blizzz
approved these changes
Mar 31, 2020
Member
|
Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
Author
|
Updated the one new test as well |
Member
|
There's more: i didn't check all steps. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
ChristophWurst
added a commit
to nextcloud/documentation
that referenced
this pull request
Apr 10, 2020
Ref nextcloud/server#19845 Ref nextcloud/server#19890 Ref nextcloud/server#19075 Ref nextcloud/server#19670 Ref nextcloud/server#19412 Ref nextcloud/server#14722 Ref nextcloud/server#19746 Ref nextcloud/server#19321 Ref nextcloud/server#19569 Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So for talks use of the comments api, we would be interested in an additional field for comments to be added. We would store there a random hash, so when the server messages are returned while you e.g. post a message we can see if the message is the one you are currently sending and already hide the temporary message.
You can currently see this sometimes when a lot of notifications are sent, that the message is shown twice for some milliseconds, because currently the temporary message is killed by the response of the post (which happens after the notifications are sent to the proxy) but in parallel the message appears already from the "waiting for new messages" request immediately after its written to the database.
So this PR adds the optional column, and only writes/updates it when the column was added already. This laziness is okay, as the impact is sloppier behaviour instead of broken behaviour in case the column was not added.