Add LoadAdditionalScriptsEvent for files_sharing #21815
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliusknorr
requested review from
ChristophWurst,
nickvergessen,
rullzer and
skjnldsv
MorrisJobke
reviewed
Jul 13, 2020
apps/files_sharing/lib/Listener/LegacyLoadAdditionalScriptsAdapter.php
Outdated
Show resolved
Hide resolved
MorrisJobke
reviewed
Jul 13, 2020
apps/files_sharing/lib/Listener/LegacyLoadAdditionalScriptsAdapter.php
Outdated
Show resolved
Hide resolved
MorrisJobke
reviewed
Jul 13, 2020
Member
|
I just noticed that you still use the newer old way. The newest one is the |
Member
MorrisJobke
approved these changes
Jul 13, 2020
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Code looks good and works 👍
MorrisJobke
force-pushed
the
enh/noid/sharing-additional-scripts-event
branch
from
16ce985 to
b329c95
Compare
Member
|
Rebased and autosquashed 🚀 |
MorrisJobke
force-pushed
the
enh/noid/sharing-additional-scripts-event
branch
from
b329c95 to
aa5e98a
Compare
Member
|
And I fixed the unit tests 🙈 |
This was referenced Jul 13, 2020
skjnldsv
approved these changes
Jul 14, 2020
ChristophWurst
added
the
pending documentation
ChristophWurst
requested changes
Jul 14, 2020
Member
ChristophWurst
left a comment
ChristophWurst
left a comment
There was a problem hiding this comment.
A theoretical concern but it's easy to fix now than having another migration path for a public event that takes three years to get rid of.
2 tasks
juliusknorr
force-pushed
the
enh/noid/sharing-additional-scripts-event
branch
from
aa5e98a to
fb01f17
Compare
Member
Author
|
Fixed, rebased and squashed. |
ChristophWurst
approved these changes
Jul 14, 2020
MorrisJobke
reviewed
Jul 14, 2020
MorrisJobke
approved these changes
Jul 14, 2020
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
Beside my little comment this looks good 👍
MorrisJobke
force-pushed
the
enh/noid/sharing-additional-scripts-event
branch
from
fb01f17 to
6c8ba1c
Compare
MorrisJobke
added
4. to release
Member
|
Ready for merge 🚀 |
skjnldsv
reviewed
Jul 15, 2020
| // Load Viewer scripts | ||
| if (class_exists(LoadViewer::class)) { | ||
| $this->eventDispatcher->dispatch(LoadViewer::class, new LoadViewer()); | ||
| $this->eventDispatcher->dispatchTyped(new LoadViewer()); |
Member
There was a problem hiding this comment.
Yep - that's the new way and makes things fully typed and thus allows the be a bit more safe.
Member
There was a problem hiding this comment.
Also you just register for the ::class and then the IDE finds properly all usages ;)
skjnldsv
reviewed
Jul 15, 2020
MorrisJobke
force-pushed
the
enh/noid/sharing-additional-scripts-event
branch
from
6c8ba1c to
1aff8d7
Compare
Signed-off-by: Julius Härtl <jus@bitgrid.net>
MorrisJobke
force-pushed
the
enh/noid/sharing-additional-scripts-event
branch
from
1aff8d7 to
217a69e
Compare
This was referenced Jul 15, 2020
MorrisJobke
removed
the
pending documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move old the
OCA\Files::loadAdditionalScriptsandOCA\Files::loadAdditionalScripts::publicShareAuthevents to our the public event API. An adapter is added as well to still dispatch the old events on the until the old ones are removed completely.Add to Critical changes for developers & admins for Nextcloud 20 #20953 if the old event is dropped