Enh/noid/sharing additional scripts event #929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
MorrisJobke
reviewed
Jul 13, 2020
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
approved these changes
Jul 13, 2020
ChristophWurst
approved these changes
Jul 14, 2020
Member
Author
|
/compile / |
Signed-off-by: npmbuildbot[bot] <npmbuildbot[bot]@users.noreply.github.com>
delete-merged-branch
bot
deleted the
enh/noid/sharing-additional-scripts-event
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #924
OCA\Files_Sharing::loadAdditionalScriptsis still an old event, so this one will use the newly introduced event class from nextcloud/server#21815Other than that the second commit will make sure that text app functionality is also available for logged in users on share links.