Skip to content

Conversation

@solracsf
Copy link
Member

Add Drone php8.0 pipelines for MariaDB10.4, MySQL8, PGSQL13

Add Drone php8.0 pipelines for MariaDB10.4, MySQL8, PGSQL13
@solracsf solracsf added the 3. to review Waiting for reviews label Nov 23, 2021
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 and CI is green minus the usual random fail

@nickvergessen
Copy link
Member

With 8.1 coming up, I think it's more likely the time to reduce the pipeline.

How likely is it that something works on mariaDB/mysql with 3 different php versions but not with 1 other?

So my suggestion is:

DB DB version PHP version Future
MariaDB 10.1 7.3
MariaDB 10.4 7.4
MariaDB 10.4 8.0
MariaDB 10.4 8.1 🔜 don't add ❌
MySQL 8.0 7.4
MySQL 8.0 8.0
MySQL 8.0 8.1 🔜
Postgres 9.6 7.3
Postgres 11 7.4
Postgres 12 7.4
Postgres 13 7.4
Postgres 13 8.0
Postgres 13 8.1 🔜

This way Postgres is tested on each PHP version once,
MySQL/MariaDB are tested on either PHP version respectively.
Should be good enough, wihtout growing the table (and therefor time) over the top

@solracsf
Copy link
Member Author

solracsf commented Nov 26, 2021

@nickvergessen tell me what you think. This should cover almost all possibilities (php8.1 not added yet).

image

@skjnldsv skjnldsv merged commit 541751d into master Nov 29, 2021
@skjnldsv skjnldsv deleted the drone-pipeline-php8.0 branch November 29, 2021 11:28
@solracsf
Copy link
Member Author

@skjnldsv backport?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants