Removed fixed Rowtype for mariadb 10.6 #30101
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While MariaDB is dropping support for ROW_TYPE "Compressed", that line causes errors while updating as described in #25436 when hard-coding that rowtype.
Member
|
Adding some docs here: https://mariadb.com/kb/en/innodb-row-formats-overview/#default-row-format |
skjnldsv
requested review from
a team,
ArtificialOwl,
come-nc and
nickvergessen
and removed request for
a team
Member
|
I would have preferred to see #25436 (comment) fixing this. But as long as we add a db unit test with MariaDB 10.6 + utf8mb4 and it works I'm fine with it. Maybe @acsfer wants to do similar to #29868 |
Member
|
Done at #30129 |
Member
|
Let's move to #30129 as a more complete global overview 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While MariaDB is dropping support for ROW_TYPE "Compressed", that line causes errors while updating as described in #25436 when hard-coding that rowtype.