Remove useless dependency on SQLite (non-PDO) #3246
Merged
+5
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
LukasReschke,
icewind1991 and
nickvergessen
Member
|
You need to update the tests for this |
* we only require the PDO driver * fixes #481 Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
fix-sqlite-dependency
branch
from
fe2915c to
4536ead
Compare
Member
Author
Fixed |
LukasReschke
approved these changes
Jan 26, 2017
icewind1991
approved these changes
Jan 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @nickvergessen @LukasReschke @icewind1991 @pmattern
I tested this and it still works (I disabled the PHP module sqlite3 ;))