Skip to content

Conversation

@ChristophWurst
Copy link
Member

It's 'getRemember' instead of 'getRememberMe', hence some warnings
were generated by phpunit.

Partially fixes

There were 3 warnings:
1) Test\Authentication\Token\DefaultTokenProviderTest::testRenewSessionTokenWithoutPassword
Trying to configure method "getRememberMe" which cannot be configured because it does not exist, has not been specified, is final, or is static
2) Test\Authentication\Token\DefaultTokenProviderTest::testRenewSessionTokenWithPassword
Trying to configure method "getRememberMe" which cannot be configured because it does not exist, has not been specified, is final, or is static
3) OCA\Provisioning_API\Tests\Controller\UsersControllerTest::testGetCurrentUserLoggedIn
PHPUnit_Framework_TestCase::getMock() is deprecated, use PHPUnit_Framework_TestCase::createMock() or PHPUnit_Framework_TestCase::getMockBuilder() instead

Seen in https://drone.nextcloud.com/nextcloud/server/5553/3

It's 'getRemember' instead of 'getRememberMe', hence some warnings
were generated by phpunit.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added 3. to review Waiting for reviews bug labels Feb 28, 2017
@ChristophWurst ChristophWurst added this to the Nextcloud 12.0 milestone Feb 28, 2017
@mention-bot
Copy link

@ChristophWurst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke and @rullzer to be potential reviewers.

@rullzer
Copy link
Member

rullzer commented Feb 28, 2017

And the tests still passes 🙈

@rullzer rullzer merged commit 383e30e into master Feb 28, 2017
@rullzer rullzer deleted the bugfix/tokenprovider-asserted-method-name branch February 28, 2017 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants