Refactor provision api app's UserControllerTest #3651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace deprecated getMock with createMock * Use createMock consistently * Use php's ::class references Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
LukasReschke,
nickvergessen and
rullzer
|
@ChristophWurst, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @LukasReschke and @schiessle to be potential reviewers. |
rullzer
approved these changes
Feb 28, 2017
MorrisJobke
approved these changes
Feb 28, 2017
| $loggedInUser = $this->getMockBuilder('OCP\IUser') | ||
| $loggedInUser = $this->getMockBuilder(IUser::class) | ||
| ->disableOriginalConstructor() | ||
| ->getMock(); |
Member
There was a problem hiding this comment.
could have used createMock as well
Member
Author
|
sure. I overlooked this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR of #3650 (comment) where I started fixing phpunit warnings. This little cleanup should make the tests a bit more robust.