GZip generated CSS/JS files #4070
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rullzer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @skjnldsv, @LukasReschke and @juliushaertl to be potential reviewers. |
MorrisJobke
reviewed
Mar 27, 2017
.htaccess
Outdated
| #### DO NOT CHANGE ANYTHING ABOVE THIS LINE #### | ||
|
|
||
| ErrorDocument 403 //core/templates/403.php | ||
| ErrorDocument 404 //core/templates/404.php |
Since in production the SCSS files are compiled once and the javascript files are combined once we can just as well gzip them aggresively. This means that once they are requested and the browser supports gzip we can just serve the gzipped file saving precious bandwidth. Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
Codecov Report
@@ Coverage Diff @@
## master #4070 +/- ##
============================================
+ Coverage 54.2% 54.22% +0.01%
- Complexity 21294 21310 +16
============================================
Files 1310 1310
Lines 81253 81293 +40
Branches 1285 1285
============================================
+ Hits 44043 44079 +36
- Misses 37210 37214 +4
Continue to review full report at Codecov.
|
rullzer
added
3. to review
Member
Author
|
This is ready for review 😄 |
LukasReschke
approved these changes
Mar 28, 2017
7 tasks
Member
|
Followup to this one for Safari: #4132 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since in production the SCSS files are compiled once and the javascript
files are combined once we can just as well gzip them aggresively.
This means that once they are requested and the browser supports gzip we
can just serve the gzipped file saving precious bandwidth.
TODO: