Fix gzip files for Safari #4132
Conversation
* Safari support gzip only if the filename does not end on .gz - so this renames them to .gzip Signed-off-by: Morris Jobke <hey@morrisjobke.de>
|
@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @juliushaertl, @rullzer and @skjnldsv to be potential reviewers. |
|
Ideally the gzip is even stripped from the respone. Because w are serving it gziped but the file is called differently ;)... But I'll look into that later. lets do it with the quick fix for now. |
|
@rullzer Its not about the URL, but somehow the FileMaker is also encoded inside of the gzip- so we would need to fix that somehow and this will get super hacky |
|
Yeah it is in the content disposition header.... let me hijack this PR to fix it in a more elegant way... |
|
@MorrisJobke could you check if https://github.com/nextcloud/server/tree/fix_dispositionname fixes it as well? |
Doesn't work. The problem is, that gizp itself encodes the name within the gz file during creation. I also tried to set a different filename in this header. You need to set a different name during creation of the file. See http://stackoverflow.com/a/32169034/520507 |
|
Stupid safari. Ok lets do it like this then |
.gz- so this renames them to .gzipcc @nextcloud/mac Please test - it's easy: open Nextcloud in Safari before and after this ;) You will notice the difference, because neither JS nor CSS is loaded before.