Fix pop over menu opacity

[MorrisJobke]

Before:

After:

Fixes #3522

cc @nextcloud/designers @ChristophWurst @nickvergessen @rullzer @skjnldsv @juliushaertl

[mention-bot]

@MorrisJobke, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @skjnldsv and @juliushaertl to be potential reviewers.

[MorrisJobke]

In comparison to #3728 this PR here doesn't change the opacity of the permanent entries in the file list itself and it additionally also fixes other pop over menus, because they were also greyed out.

[MorrisJobke]

it additionally also fixes other pop over menus, because they were also greyed out.

vs

[codecov-io]

Codecov Report

Merging #4082 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #4082      +/-   ##
============================================
+ Coverage     54.24%   54.24%   +<.01%     
+ Complexity    21285    21278       -7     
============================================
  Files          1310     1310              
  Lines         81187    81196       +9     
  Branches       1284     1284              
============================================
+ Hits          44037    44044       +7     
- Misses        37150    37152       +2

Impacted Files	Coverage Δ	Complexity Δ
apps/files/lib/App.php	27.27% <0%> (-47.73%)	2% <0%> (ø)
lib/private/NavigationManager.php	53.03% <0%> (-33.54%)	39% <0%> (+13%)
core/js/js.js	62.17% <0%> (-0.15%)	0% <0%> (ø)
lib/private/Server.php	92.97% <0%> (-0.06%)	120% <0%> (ø)
core/templates/layout.user.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
lib/private/TemplateLayout.php	0% <0%> (ø)	33% <0%> (-1%)	⬇️
settings/js/apps.js	26.71% <0%> (+0.12%)	0% <0%> (ø)	⬇️
lib/private/legacy/app.php	50% <0%> (+3.07%)	228% <0%> (-19%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd5d73...0322e7a. Read the comment docs.

[jancborchardt]

it additionally also fixes other pop over menus, because they were also greyed out.

This was intended to show which of the states is active and it’s a regression that it’s gone. Fixed it with my commit :)

[jancborchardt]

Let’s do it! :)

[MorrisJobke]

cc @nickvergessen @rullzer @LukasReschke