Three dots menu in files is made darker

[aarushi15002]

I have tried and rectified the issue : Three dots menu in files in greyed out

[mention-bot]

@aarushi15002, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jancborchardt, @butonic and @MorrisJobke to be potential reviewers.

[ChristophWurst]

Hey @aarushi15002,

thanks a lot for your contribution. Is there a ticket or bug report this pull request fixes? Otherwise it would be great if you could describe what problem this changes fixes. Also screenshots of before/after can be useful with design changes.
Are you the author of the code? GitHub shows that two different users authored and created the PR.

[aarushi15002]

This pull request fixes a bug report. The list in the three dots menu as well as the dots were barely visible earlier but after the changes it is better.
before:

after changes:

Also I am the author of this pull request . I have two github accounts so by mistake I made the PR from the other mail id . Sorry for the inconvenience caused.

[MorrisJobke]

@ChristophWurst @aarushi15002 I guess this is the PR that should fix #3522

[innocent-rajan]

According to me the changes are perfectly fine.
And by seeing the error the are getting think its not the issue with their code but with the server as far as i can understand.
Please let me also know what the exact error is.

[ChristophWurst]

thanks @MorrisJobke.

To me it looks best if the opacity is removed completely. cc @nextcloud/designers

[innocent-rajan]

This doesn't look that good rather looks too dark. Making the opacity as 0.5 will be better.

[ChristophWurst]

Okay, I wasn't clear about what I've changed. The opacity on the icons is almost fine. However, the opacity on the menu items is way to low. The text is very hard to read since the contrast is low. We might need a specific rule for that.

[aarushi15002]

Size, Modifier are defined to of the color they appeared before, which means that no opacity is associated with is. Where as if we do that then we need to change the whole website color and the contrast which makes no sense according to me.
So a better option is to make the opactity to .5 from .3 as .3 looks too dim.
This looks better i guess.

[jancborchardt]

.5 opacity seems good, great point. Please make sure to also test it on mobile as there needs to be sufficient contrast to the files which have been shared – for them the share icon will be shown a bit darker, should be full opacity.

Can you look at the linked issue #3522 to make sure that is also fixed?

Thanks! :)

[rullzer]

@jancborchardt is this still needed now that #4082 is in?

[jancborchardt]

@aarushi15002 @innocent-rajan can you comment please? Make sure that this pull request is rebased on latest master changes. :)

[aarushi15002]

Yeah I need to check once and then will let you know. And the code above resolves #3522.

[MorrisJobke]

I just checked on this and it doesn't result in any change, because there is another rule that overwrites this one. I will close this and may have a look at this opacity mess in files.scss.

Thanks for your help @aarushi15002 anyways :) Maybe check out our other issues - the starters are quite good ones: https://github.com/nextcloud/server/issues?q=is%3Aissue+is%3Aopen+label%3A%22starter+issue%22

[MorrisJobke]

@aarushi15002 and here it is: #4386