Skip to content

Conversation

@MorrisJobke
Copy link
Member

@nextcloud/designers Please help reviewing this. It makes our lives a lot easier. Fewer rules, more clear logic with opacity of .3, .7 and 1. Best to be reviewed by looking at the resulting CSS. It cleans up the CSS mess we created by dumping more and more rules on top of each other and duck taping it with !important statements.

I tested this in multiple browsers. I tested the menu in the public sharing page, the files app itself, the share menu in the sidebar and the personal page menus. All look the same as before, but now without a single !important rule.

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YES!

* fix mess with menus and actions in the files app
* reduces amount of !important usages
* keeps the behaviour on mobile as well as on desktop

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks the same to me. 🙈

@MorrisJobke
Copy link
Member Author

Looks the same to me. 🙈

That is because it is actual the same, but with fewer rules 😉

@MorrisJobke MorrisJobke merged commit 3c892d6 into master Apr 19, 2017
@MorrisJobke MorrisJobke deleted the improve-menu-css branch April 19, 2017 18:14
@jancborchardt
Copy link
Member

So fucking cool, you rock @MorrisJobke! 🎉

@MorrisJobke
Copy link
Member Author

😏

@derkostka
Copy link
Contributor

derkostka commented May 14, 2017

Do i need to change anything in my config ?
After upgrading from NV 11 to NC12 Beta, i get some errors, due to the changed file type from .css to .scss.

I think this is related somehow to #4857

{"reqId":"W8kPlOwis3dsqXFivE3Q","level":3,"time":"May 14, 2017 11:54:26","remoteAddr":"127.0.0.1","user":"me@mymail.com","app":"lib","method":"GET","url":"/apps/files/","message":"ResourceLocator can not find a web root (root: /var/www/nextcloud/apps/files, file: css/files/merged.css, webRoot: , throw: true)","userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36","version":"12.0.0.19"}
{"reqId":"W8kPlOwis3dsqXFivE3Q","level":3,"time":"May 14, 2017 11:54:29","remoteAddr":"127.0.0.1","user":"me@mymail.com","app":"lib","method":"GET","url":"/apps/files/","message":"ResourceLocator can not find a web root (root: /var/www/nextcloud/apps/files_sharing, file: css/files_sharing/mergedAdditionalStyles.css, webRoot: , throw: true)","userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36","version":"12.0.0.19"}
{"reqId":"W8kPlOwis3dsqXFivE3Q","level":3,"time":"May 14, 2017 11:54:31","remoteAddr":"127.0.0.1","user":"me@mymail.com","app":"lib","method":"GET","url":"/apps/files/","message":"ResourceLocator can not find a web root (root: /var/www/nextcloud/apps/files_texteditor, file: css/files_texteditor/merged.css, webRoot: , throw: true)","userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/58.0.3029.110 Safari/537.36","version":"12.0.0.19"}

@MorrisJobke
Copy link
Member Author

Open please a ticket and place your configuration there as well (see issue template)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc. technical debt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants