-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Improve menu CSS #4386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve menu CSS #4386
Conversation
skjnldsv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
YES!
* fix mess with menus and actions in the files app * reduces amount of !important usages * keeps the behaviour on mobile as well as on desktop Signed-off-by: Morris Jobke <hey@morrisjobke.de>
f563003 to
4be923e
Compare
rullzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks the same to me. 🙈
That is because it is actual the same, but with fewer rules 😉 |
|
So fucking cool, you rock @MorrisJobke! 🎉 |
|
😏 |
|
Do i need to change anything in my config ? I think this is related somehow to #4857
|
|
Open please a ticket and place your configuration there as well (see issue template) |
@nextcloud/designers Please help reviewing this. It makes our lives a lot easier. Fewer rules, more clear logic with opacity of .3, .7 and 1. Best to be reviewed by looking at the resulting CSS. It cleans up the CSS mess we created by dumping more and more rules on top of each other and duck taping it with
!importantstatements.I tested this in multiple browsers. I tested the menu in the public sharing page, the files app itself, the share menu in the sidebar and the personal page menus. All look the same as before, but now without a single
!importantrule.