Add tooltips to LDAP wizard special attributtes #4145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> Update settings.php Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> Update settings.php Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de> Update settings.php Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
blizzz
added
3. to review
|
@blizzz, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @jancborchardt and @MorrisJobke to be potential reviewers. |
Codecov Report
@@ Coverage Diff @@
## master #4145 +/- ##
============================================
- Coverage 54.18% 54.18% -0.01%
Complexity 21316 21316
============================================
Files 1309 1309
Lines 81343 81343
Branches 1285 1285
============================================
- Hits 44079 44078 -1
- Misses 37264 37265 +1
Continue to review full report at Codecov.
|
rullzer
approved these changes
Mar 29, 2017
This was referenced Mar 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Downstream of owncloud/user_ldap#54
Simple to review: only adds tooltips :) @nextcloud/ldap