Add tooltips to LDAP wizard special attributtes #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davitol, thanks for your PR! By analyzing the history of the files in this pull request, we identified @blizzz, @LukasReschke and @jancborchardt to be potential reviewers. |
jvillafanez
reviewed
Feb 16, 2017
templates/settings.php
Outdated
| <p><label for="ldap_email_attr"><?php p($l->t('Email Field'));?></label><input type="text" id="ldap_email_attr" name="ldap_email_attr" data-default="<?php p($_['ldap_email_attr_default']); ?>" /></p> | ||
| <p><label for="ldap_quota_attr"><?php p($l->t('Quota Field'));?></label><input type="text" id="ldap_quota_attr" name="ldap_quota_attr" data-default="<?php p($_['ldap_quota_attr_default']); ?>" title="<?php p($l->t('Leave empty for ownCloud quota. Otherwise, specify an LDAP/AD attribute.'));?>" /></p> | ||
| <p><label for="ldap_quota_def"><?php p($l->t('Quota Default'));?></label><input type="text" id="ldap_quota_def" name="ldap_quota_def" data-default="<?php p($_['ldap_quota_def_default']); ?>" title="<?php p($l->t('Override ownCloud default quota for LDAP users who do not have a quota set in the Quota Field. | ||
Member
|
Tested 👍 It might need a second review for the texts. |
PVince81
reviewed
Feb 16, 2017
templates/settings.php
Outdated
| <p><label for="ldap_quota_def"><?php p($l->t('Quota Default'));?></label><input type="text" id="ldap_quota_def" name="ldap_quota_def" data-default="<?php p($_['ldap_quota_def_default']); ?>" title="<?php p($l->t('in bytes'));?>" /></p> | ||
| <p><label for="ldap_email_attr"><?php p($l->t('Email Field'));?></label><input type="text" id="ldap_email_attr" name="ldap_email_attr" data-default="<?php p($_['ldap_email_attr_default']); ?>" /></p> | ||
| <p><label for="ldap_quota_attr"><?php p($l->t('Quota Field'));?></label><input type="text" id="ldap_quota_attr" name="ldap_quota_attr" data-default="<?php p($_['ldap_quota_attr_default']); ?>" title="<?php p($l->t('Leave empty for ownCloud quota. Otherwise, specify an LDAP/AD attribute.'));?>" /></p> | ||
| <p><label for="ldap_quota_def"><?php p($l->t('Quota Default'));?></label><input type="text" id="ldap_quota_def" name="ldap_quota_def" data-default="<?php p($_['ldap_quota_def_default']); ?>" title="<?php p($l->t('Override ownCloud default quota for LDAP users who do not have a quota set in the Quota Field.'));?>" /></p> |
Contributor
There was a problem hiding this comment.
never use ownCloud in a visible text. Should use the product name variable from the theme.
But here I suggest to just remove "ownCloud" from the text.
Contributor
|
@settermjd can you check the wording ? |
Contributor
Author
|
@settermjd Kindly remember |
Contributor
Author
|
Last train to get this merged in oC10 🚆 |
Contributor
|
Let's merge this anyway, even if the wording might not be perfect it's better than nothing. If changes are required, please submit a separate PR. |
|
Sorry, not sure how I missed this. |
|
fwiw, looks fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #53
@jvillafanez