show error message when "files-drop" upload fails #4545
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@individual-it, thanks for your PR! By analyzing the history of the files in this pull request, we identified @LukasReschke, @blizzz and @rullzer to be potential reviewers. |
Signed-off-by: Artur Neumann <info@individual-it.net>
Signed-off-by: Artur Neumann <info@individual-it.net>
Codecov Report
@@ Coverage Diff @@
## master #4545 +/- ##
============================================
- Coverage 54.26% 54.26% -0.01%
Complexity 21897 21897
============================================
Files 1348 1348
Lines 83971 83975 +4
Branches 1334 1333 -1
============================================
+ Hits 45564 45566 +2
- Misses 38407 38409 +2
|
LukasReschke
approved these changes
May 1, 2017
blizzz
approved these changes
May 2, 2017
| e.preventDefault(); | ||
| }); | ||
| var output = this.template(); | ||
| var fileName = undefined; |
Member
There was a problem hiding this comment.
not necessary to assign undefined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when upload fails for any reason the user gets a notification and the icon is set to an exclamation mark
if the user should not receive any information about why the upload failed this should fix #3726 and partly #4389