Skip to content

feat: Make it possible to customize share link tokens #49317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Pytal merged 12 commits into from
Jan 16, 2025
Merged

feat: Make it possible to customize share link tokens #49317

Pytal merged 12 commits into from
Jan 16, 2025

Conversation

@Pytal
Copy link
Member

@Pytal Pytal commented Nov 15, 2024 •
edited
Loading

Summary

  • Set custom share link tokens
  • Add admin switch

Checklist

@Pytal Pytal added this to the Nextcloud 31 milestone Nov 15, 2024
@Pytal Pytal self-assigned this Nov 15, 2024
@Pytal Pytal force-pushed the feat/edit-share-token branch from 948ea93 to 5578770 Compare December 17, 2024 00:04
@Pytal Pytal changed the title feat: Allow editing public share token feat: Make it possible to customize share link tokens Dec 17, 2024
@Pytal Pytal force-pushed the feat/edit-share-token branch from 5578770 to f57a605 Compare December 17, 2024 00:18
@Pytal Pytal marked this pull request as ready for review December 17, 2024 00:24
@Pytal Pytal requested a review from provokateurin as a code owner December 17, 2024 00:24
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 17, 2024
@Pytal Pytal requested review from come-nc and nfebe December 17, 2024 00:25
provokateurin
provokateurin requested changes Dec 17, 2024
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me 👍

@Pytal Pytal force-pushed the feat/edit-share-token branch from f57a605 to 14bea75 Compare January 4, 2025 00:26
@Pytal Pytal requested a review from provokateurin January 4, 2025 00:26
provokateurin
provokateurin requested changes Jan 6, 2025
View reviewed changes
@blizzz blizzz mentioned this pull request Jan 8, 2025
Merged
@Pytal Pytal force-pushed the feat/edit-share-token branch from 14bea75 to 6bcbc5a Compare January 9, 2025 22:44
@Pytal Pytal requested a review from provokateurin January 9, 2025 22:48
@Pytal Pytal force-pushed the feat/edit-share-token branch 3 times, most recently from 3801197 to a89f31d Compare January 9, 2025 23:25
provokateurin
provokateurin approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Pytal Pytal requested a review from artonge January 13, 2025 23:48
@skjnldsv skjnldsv mentioned this pull request Jan 14, 2025
Merged
@susnux susnux force-pushed the feat/edit-share-token branch from a89f31d to 3210fbd Compare January 15, 2025 11:07
@susnux

This comment was marked as outdated.

Sign in to view
@Pytal Pytal force-pushed the feat/edit-share-token branch from 06edc91 to f662bb2 Compare January 15, 2025 22:39
@Pytal

This comment was marked as outdated.

Sign in to view
@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 15, 2025
Pytal added 11 commits January 15, 2025 15:49
@Pytal
feat(sharing): Allow updating share token
f92875c 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(sharing): Fetch a unique generated token
beffb26 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore(openapi): Update spec
fa110e2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(sharing): Make it possible to customize share link tokens
cdc65b6 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(sharing): Add shareapi_allow_custom_tokens config
8b26383 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(sharing): Add custom_tokens capability
4d78de4 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(sharing): Respect admin custom tokens setting
0eb39d7 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
feat(sharing): Toggle custom tokens setting as admin
1a43fc5 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore(openapi): Update capabilities spec
c28791f 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
chore: Update autoloaders
3c62d68 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
test: Update tests
42d997b 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal force-pushed the feat/edit-share-token branch from 9d14a3c to 42d997b Compare January 15, 2025 23:51
@Pytal
Copy link
Member Author

Pytal commented Jan 15, 2025

/compile

@nextcloud-command
chore(assets): Recompile assets
a3cfc4f 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Pytal Pytal merged commit 76ed55a into master Jan 16, 2025
188 checks passed
@Pytal Pytal deleted the feat/edit-share-token branch January 16, 2025 00:25
@skjnldsv skjnldsv mentioned this pull request Jan 16, 2025
Merged
@JonathanTreffler JonathanTreffler mentioned this pull request Jan 25, 2025
Open
@shadowstrike114 shadowstrike114 mentioned this pull request Mar 2, 2025
Closed
8 tasks
@solracsf solracsf mentioned this pull request Mar 8, 2025
Closed
4 tasks
@ALLADMINdotRU
Copy link

ALLADMINdotRU commented Apr 22, 2025 •
edited
Loading

31.0.2 if the link name contains an underscore then the link does not work
Steps to reproduce
Share a directory with a public link
Change the link to something containing an underscore.
Open link in a new window

@susnux
Copy link
Contributor

susnux commented Apr 22, 2025

@ALLADMINdotRU allowed characters are only letters, numbers and the dash. If you need underscores open a feature request.

@nextcloud nextcloud locked as resolved and limited conversation to collaborators Apr 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@provokateurin provokateurin provokateurin approved these changes

@sorbaugh sorbaugh sorbaugh approved these changes

@nfebe nfebe Awaiting requested review from nfebe

@come-nc come-nc Awaiting requested review from come-nc

@artonge artonge Awaiting requested review from artonge

Assignees

@Pytal Pytal

Labels

4. to release Ready to be released and/or waiting for tests to finish enhancement feature: sharing

Projects

None yet

Milestone

Nextcloud 31

Development

Successfully merging this pull request may close these issues.

Allow to specify the token of a public share / share renaming

7 participants

@Pytal @susnux @ALLADMINdotRU @provokateurin @sorbaugh @nextcloud-command