Allow to find local users by their email address

[nickvergessen]

• Allow type-ahead of local users via email address
• If we match a complete email address, use a local user share and hide email + remote share options

I guess tests may fail, will adjust them then later.

[mention-bot]

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @schiessle and @icewind1991 to be potential reviewers.

[schiessle]

It looks like two things are missing:

• We should hide the email option if we match a exact federated cloud id (we query the local address books and the lookup server for it)
• We should hide the remote share option if we match a exact email address of non-local users.

[nickvergessen]

Those two things should already be the case, did you test them?

[schiessle]

I tested it now with a user who where email address === login name. I think that's quite common on some LDAP setups and the reason why we didn't searched the system address book.

Setup:

• a user with the username "user@server.com" and a email address "user@server.com"
• create system address book sudo -u www-data ./occ dav:sync-system-addressbook

Now I typed "user@server":

Since there is no exact match this seems to be fine.

Then after I completed the email address it looks like that:

Now we have a exact match and the result is a bit confusing to me. We have two options but what are the differences? I assume that user@server.com (user@server.com) is the email address like in the first screenshot, but where is the (email) gone? The first option user@server.com is the local user, right? I think in this case we shouldn't show the email option, right?

[nickvergessen]

Ah okay, yeah I didn't think about name === email, will have a look

[nickvergessen]

Done and added a test

[codecov]

Codecov Report

Merging #5384 into master will increase coverage by <.01%.
The diff coverage is 50%.

@@             Coverage Diff              @@
##             master    #5384      +/-   ##
============================================
+ Coverage     54.14%   54.15%   +<.01%     
- Complexity    22312    22323      +11     
============================================
  Files          1381     1380       -1     
  Lines         85449    85497      +48     
  Branches       1325     1325              
============================================
+ Hits          46267    46298      +31     
- Misses        39182    39199      +17

Impacted Files	Coverage Δ	Complexity Δ
...es_sharing/lib/Controller/ShareesAPIController.php	66.03% <50%> (-2%)	110 <5> (+9)
apps/dav/lib/CalDAV/Calendar.php	73.23% <0%> (-1.03%)	52% <0%> (ø)
lib/base.php	2.97% <0%> (-0.01%)	173% <0%> (ø)
config/config.sample.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
apps/user_ldap/appinfo/app.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
settings/personal.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
settings/templates/personal.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
apps/user_ldap/templates/settings.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
apps/files/templates/appnavigation.php	0% <0%> (ø)	0% <0%> (ø)	⬇️
lib/private/Comments/ManagerFactory.php	100% <0%> (ø)	2% <0%> (ø)	⬇️
... and 5 more

[schiessle]

looks good now!

[MorrisJobke]

Tested and works:

And then the share drop down only shows the display name:

👍

[MorrisJobke]

Ping @nickvergessen for the backport

[blizzz]

I backported it quickly → #5428