[stable12] Allow to find local users by their email address #5428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow to find local users by their email address Signed-off-by: Joas Schilling <coding@schilljs.com> Make sure to only add system users once Signed-off-by: Joas Schilling <coding@schilljs.com> Add unit test Signed-off-by: Joas Schilling <coding@schilljs.com>
|
|
||
| if (isset($contact['isLocalSystemBook'])) { | ||
| if ($exactEmailMatch) { | ||
| $cloud = $this->cloudIdManager->resolveCloudId($contact['CLOUD'][0]); |
There was a problem hiding this comment.
This addition led to a crash on my NC instance: users cannot share anymore with users with an email address set in NC.
For user "pab", with an email address, $contact['CLOUD'][0] resolves to "pab@" and resolveCloudId fails saying: Invalid cloud id.
See here for full error stack: https://help.nextcloud.com/t/cant-share-to-a-local-user/12339/4?u=pab
There was a problem hiding this comment.
Can someone tell me where the ['CLOUD'][0] value is supposed to be found? Is there a doc of the contactsManager to see to which fields of the database CLOUD shall be linked to?
Member
There was a problem hiding this comment.
cc @nickvergessen this is where this weird share name could come from
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5384 to stable12
Works also with LDAP users btw. Just cherry-picked, did not need to touch code → 👍 from me