-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Catch exceptions on error of cloud id resolution #6099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @schiessle and @PVince81 to be potential reviewers. |
This was referenced Aug 14, 2017
icewind1991
approved these changes
Aug 14, 2017
Codecov Report
@@ Coverage Diff @@
## master #6099 +/- ##
============================================
- Coverage 53.12% 53.12% -0.01%
- Complexity 22803 22806 +3
============================================
Files 1407 1407
Lines 88239 88248 +9
Branches 1327 1327
============================================
+ Hits 46878 46879 +1
- Misses 41361 41369 +8
|
MorrisJobke
approved these changes
Aug 14, 2017
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
dbcadc7 to
bd65244
Compare
Member
|
Rebased to retrigger CI. |
LukasReschke
approved these changes
Aug 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3457
Replace #6076