Skip to content

Conversation

@nickvergessen
Copy link
Member

Fix #3457

Replace #6076

@mention-bot
Copy link

@nickvergessen, thanks for your PR! By analyzing the history of the files in this pull request, we identified @rullzer, @schiessle and @PVince81 to be potential reviewers.

@codecov
Copy link

codecov bot commented Aug 14, 2017

Codecov Report

Merging #6099 into master will decrease coverage by <.01%.
The diff coverage is 23.07%.

@@             Coverage Diff              @@
##             master    #6099      +/-   ##
============================================
- Coverage     53.12%   53.12%   -0.01%     
- Complexity    22803    22806       +3     
============================================
  Files          1407     1407              
  Lines         88239    88248       +9     
  Branches       1327     1327              
============================================
+ Hits          46878    46879       +1     
- Misses        41361    41369       +8
Impacted Files Coverage Δ Complexity Δ
...es_sharing/lib/Controller/ShareesAPIController.php 64.47% <23.07%> (-1.57%) 114 <0> (+3)
apps/comments/lib/EventHandler.php 79.16% <0%> (-8.34%) 7% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.77% <0%> (+0.24%) 136% <0%> (ø) ⬇️
lib/private/Files/Cache/Propagator.php 96.2% <0%> (+1.26%) 16% <0%> (ø) ⬇️
apps/files_trashbin/lib/Expiration.php 91.93% <0%> (+1.61%) 29% <0%> (ø) ⬇️

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 14, 2017
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
@MorrisJobke MorrisJobke force-pushed the issue-3457-no-exception-on-sharee-error branch from dbcadc7 to bd65244 Compare August 14, 2017 20:21
@MorrisJobke
Copy link
Member

Rebased to retrigger CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug feature: sharing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants