Skip to content

Apply password policy on user creation #711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schiessle merged 1 commit into from
Aug 8, 2016
Merged

Apply password policy on user creation #711

schiessle merged 1 commit into from
Aug 8, 2016

Conversation

@michag86
Copy link
Contributor

@michag86 michag86 commented Aug 3, 2016

Fix for #538

@mention-bot
Copy link

mention-bot commented Aug 3, 2016

@michag86, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nickvergessen, @icewind1991 and @MorrisJobke to be potential reviewers

@MorrisJobke
Copy link
Member

MorrisJobke commented Aug 3, 2016

Tested and works 👍

@MorrisJobke MorrisJobke added this to the Nextcloud 11.0 milestone Aug 3, 2016
@MorrisJobke
Copy link
Member

MorrisJobke commented Aug 3, 2016

cc @schiessle @rullzer @nickvergessen

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Aug 3, 2016
@nickvergessen
Copy link
Member

nickvergessen commented Aug 3, 2016

integration tests fail

@MorrisJobke
Copy link
Member

MorrisJobke commented Aug 3, 2016 


--- Failed scenarios:

    /drone/src/github.com/nextcloud/server/build/integration/features/sharing-v1.feature:907

  Scenario: Merging shares for recipient when shared from outside with user then group and recipient renames in between                                # /drone/src/github.com/nextcloud/server/build/integration/features/sharing-v1.feature:907
    Given As an "admin"                                                                                                                                # FeatureContext::asAn()
[Wed Aug  3 10:46:14 2016] ::1:52424 [404]: /ocs/v2.php/cloud/users/user0
[Wed Aug  3 10:46:14 2016] ::1:52425 [200]: /ocs/v1.php/cloud/users
[Wed Aug  3 10:46:15 2016] ::1:52426 [200]: /ocs/v1.php/cloud/users/user0
[Wed Aug  3 10:46:15 2016] ::1:52427 [200]: /ocs/v2.php/cloud/users/user0
    And user "user0" exists                                                                                                                            # FeatureContext::assureUserExists()
[Wed Aug  3 10:46:15 2016] ::1:52428 [404]: /ocs/v2.php/cloud/users/user1
[Wed Aug  3 10:46:15 2016] ::1:52429 [200]: /ocs/v1.php/cloud/users
[Wed Aug  3 10:46:16 2016] ::1:52430 [200]: /ocs/v1.php/cloud/users/user1
[Wed Aug  3 10:46:16 2016] ::1:52431 [200]: /ocs/v2.php/cloud/users/user1
    And user "user1" exists                                                                                                                            # FeatureContext::assureUserExists()
[Wed Aug  3 10:46:16 2016] ::1:52432 [404]: /ocs/v2.php/cloud/groups/group1
[Wed Aug  3 10:46:17 2016] ::1:52433 [200]: /ocs/v1.php/cloud/groups
[Wed Aug  3 10:46:17 2016] ::1:52434 [200]: /ocs/v2.php/cloud/groups/group1
    And group "group1" exists                                                                                                                          # FeatureContext::assureGroupExists()
[Wed Aug  3 10:46:17 2016] ::1:52435 [200]: /ocs/v2.php/cloud/users/user1/groups
[Wed Aug  3 10:46:17 2016] ::1:52436 [200]: /ocs/v1.php/cloud/users/user1/groups
[Wed Aug  3 10:46:17 2016] ::1:52437 [200]: /ocs/v2.php/cloud/users/user1/groups
    And user "user1" belongs to group "group1"                                                                                                         # FeatureContext::assureUserBelongsToGroup()
[Wed Aug  3 10:46:17 2016] ::1:52438 [201]: /remote.php/webdav/merge-test-outside-groups-renamebeforesecondshare
    And user "user0" created a folder "merge-test-outside-groups-renamebeforesecondshare"                                                              # FeatureContext::userCreatedAFolder()
[Wed Aug  3 10:46:18 2016] ::1:52439 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares?path=merge-test-outside-groups-renamebeforesecondshare
[Wed Aug  3 10:46:18 2016] ::1:52440 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
[Wed Aug  3 10:46:18 2016] ::1:52441 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares?path=merge-test-outside-groups-renamebeforesecondshare
    When folder "merge-test-outside-groups-renamebeforesecondshare" of user "user0" is shared with user "user1"                                        # FeatureContext::assureFileIsShared()
[Wed Aug  3 10:46:18 2016] ::1:52442 [201]: /remote.php/webdav/merge-test-outside-groups-renamebeforesecondshare
    And User "user1" moved folder "/merge-test-outside-groups-renamebeforesecondshare" to "/merge-test-outside-groups-renamebeforesecondshare-renamed" # FeatureContext::userMovedFile()
[Wed Aug  3 10:46:18 2016] ::1:52443 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares?path=merge-test-outside-groups-renamebeforesecondshare
[Wed Aug  3 10:46:18 2016] ::1:52444 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares
[Wed Aug  3 10:46:19 2016] ::1:52445 [200]: /ocs/v1.php/apps/files_sharing/api/v1/shares?path=merge-test-outside-groups-renamebeforesecondshare
    And folder "merge-test-outside-groups-renamebeforesecondshare" of user "user0" is shared with group "group1"                                       # FeatureContext::assureFileIsSharedWithGroup()
[Wed Aug  3 10:46:19 2016] ::1:52446 [401]: /remote.php/webdav/merge-test-outside-groups-renamebeforesecondshare-renamed
[Wed Aug  3 10:46:19 2016] ::1:52447 [404]: /remote.php/webdav/merge-test-outside-groups-renamebeforesecondshare-renamed
    Then as "user1" gets properties of folder "merge-test-outside-groups-renamebeforesecondshare-renamed" with                                         # FeatureContext::asGetsPropertiesOfFolderWith()
      | {http://owncloud.org/ns}permissions |
      HTTP error: 404 (Sabre\DAV\Exception)
    And the single response should contain a property "{http://owncloud.org/ns}permissions" with value "SRDNVCK"                                       # FeatureContext::theSingleResponseShouldContainAPropertyWithValue()
    And as "user1" the folder "merge-test-outside-groups-renamebeforesecondshare" does not exist                                                       # FeatureContext::asTheFileOrFolderDoesNotExist()

@michag86
Copy link
Contributor Author

michag86 commented Aug 3, 2016

I do not understand how the error is related to my modification. 😔

@nickvergessen
Copy link
Member

nickvergessen commented Aug 3, 2016

@rullzer is something broken thereon master?

@rullzer
Copy link
Member

rullzer commented Aug 6, 2016

Yes will rebase when "fix" is in master

@schiessle
Copy link
Member

schiessle commented Aug 8, 2016

tested, works! Thanks for your contribution!

@schiessle
Copy link
Member

schiessle commented Aug 8, 2016

👍

@schiessle
Copy link
Member

schiessle commented Aug 8, 2016

failing tests are unrelated

@schiessle schiessle merged commit 727cd6a into master Aug 8, 2016
@schiessle schiessle deleted the password-policy-on-createUser branch August 8, 2016 09:17
@michag86 michag86 mentioned this pull request Aug 25, 2016
Closed
GitHubUser4234 pushed a commit to GitHubUser4234/server that referenced this pull request Aug 30, 2016
@schiessle
Merge pull request nextcloud#711 from nextcloud/password-policy-on-cr…
c35b234 
…eateUser

Apply password policy on user creation
@nickvergessen
Copy link
Member

nickvergessen commented Sep 12, 2016

Should backport this @schiessle ?

@michag86 michag86 mentioned this pull request Sep 12, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 11.0

Development

Successfully merging this pull request may close these issues.

7 participants

@michag86 @mention-bot @MorrisJobke @nickvergessen @rullzer @schiessle