Re-optimize and clean up settings, social and logo icons #7209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until now it was safe to assume that every file was readable by its owner, so there was no need to return whether the file was readable or not. However, with the introduction of end to end encryption that is no longer the case, and it is now necessary to explicitly provide that information. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Now a file gets its directory permissions only if it contained no permissions (they were undefined or null), but not if its permissions were set to "NONE". Besides that, now file actions that do not require any permission on the file to be performed can be used on files that have no permissions. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The Details and the Favorite actions do not require any permission on the files to be performed. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
The first parameter of "apply" must be the object to act as "this", and the Promise callback gets the parameters provided in the "resolve". Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Now that these tests are executed they are revealed to be partially obsolete; they were fixed to match the current parsing behaviour. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Now that the permissions returned by the server specify whether a file is readable or not the frontend no longer needs to assume that every file is readable. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: Marin Treselj <marin@pixelipo.com>
This was referenced Nov 17, 2017
Closed
If not broken extremely long words overflow their container. Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #7209 +/- ##
============================================
+ Coverage 50.84% 50.85% +<.01%
- Complexity 24545 24547 +2
============================================
Files 1585 1585
Lines 93796 93801 +5
Branches 1354 1354
============================================
+ Hits 47687 47698 +11
+ Misses 46109 46103 -6
|
the contacts popovermenu is also present and is being replaces, ending up in two permission popupmenus with checkboxes duplicating the id, breaking further permission changes. plus, fixing a selector Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
…g-words-in-comments Force breaks on extremely long words in comments
Fixes #7119 Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
If there is no internet connection don't try to contact appstore
skjnldsv
reviewed
Nov 18, 2017
settings/img/users.svg
Outdated
| @@ -1 +1 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" height="16" width="16" version="1"><path color="#000" fill="none" d="M-62.897-32.993h163.31v97.986h-163.31z"/><path style="block-progression:tb;text-transform:none;text-indent:0" d="M4.118 1.71c-1.113 0-2.058.815-2.058 1.866.008.332.038.742.236 1.608v.02l.022.022c.063.183.156.287.278.43.123.14.27.31.407.45l.043.042c.028.12.06.25.086.365.066.307.06.525.043.6-.478.168-1.074.368-1.608.6-.3.13-.57.247-.793.386-.222.138-.442.243-.514.556V8.7c-.07.643-.176 1.59-.257 2.228a.352.352 0 0 0 .17.343c.97.525 2.46.736 3.945.73 1.485-.006 2.962-.23 3.9-.73a.352.352 0 0 0 .172-.342c-.025-.2-.057-.65-.085-1.093-.028-.443-.053-.88-.086-1.136a.346.346 0 0 0-.087-.172c-.298-.356-.743-.574-1.264-.793-.477-.2-1.035-.41-1.587-.644-.03-.067-.062-.268 0-.577.016-.083.042-.172.064-.257l.15-.172c.123-.14.255-.287.364-.43.11-.14.2-.262.258-.427l.022-.022c.224-.904.224-1.28.236-1.607v-.022c0-1.05-.945-1.865-2.058-1.865zM10.004 0c-1.623 0-3 1.187-3 2.72.01.483.055 1.08.344 2.342v.032l.03.03c.094.267.23.42.407.626s.39.45.594.656l.06.063c.04.173.09.36.126.53.097.448.087.766.063.875-.7.245-1.566.536-2.345.875-.437.19-.833.36-1.156.562-.325.203-.647.356-.75.813-.003.02-.003.042 0 .063-.103.938-.258 2.318-.376 3.25a.513.513 0 0 0 .25.5c1.413.763 3.585 1.07 5.75 1.062s4.32-.334 5.687-1.062a.513.513 0 0 0 .25-.5c-.037-.292-.083-.948-.124-1.594-.04-.646-.076-1.282-.125-1.656a.503.503 0 0 0-.124-.25c-.435-.52-1.084-.837-1.844-1.157-.693-.29-1.506-.594-2.312-.936-.045-.1-.09-.393 0-.844.024-.12.062-.25.094-.375l.218-.25c.18-.204.372-.418.532-.625.16-.206.29-.383.375-.625l.03-.03c.327-1.32.327-1.87.344-2.345v-.03c0-1.533-1.377-2.72-3-2.72z" color="#000"/></svg> | |||
| <svg xmlns="http://www.w3.org/2000/svg" viewbox="0 0 16 16" height="16" width="16" version="1.1"><path d="m9 1c-1.746 0-3 1.43-3 2.8 0 1.4 0.1 2.4 0.8 3.5 0.224 0.29 0.485 0.35 0.7 0.6 0.135 0.5 0.24 1 0.1 1.5-0.436 0.153-0.85 0.332-1.27 0.5-0.51-0.273-1.1-0.5-1.61-0.7-0.07-0.28-0.02-0.487 0.05-0.75 0.12-0.125 0.23-0.18 0.36-0.3 0.37-0.45 0.39-1.21 0.39-1.75 0-0.8-0.72-1.4-1.5-1.4-0.87 0-1.5 0.72-1.5 1.4h-0.02c0 0.7 0.05 1.2 0.4 1.75 0.1 0.15 0.242 0.175 0.35 0.3 0.0674 0.25 0.121 0.5 0.05 0.75-0.64 0.223-1.244 0.5-1.8 0.8-0.42 0.3-0.233 0.182-0.5 1.15-0.124 0.5 1.3 0.73 2.32 0.81-0.05 0.275-0.12 0.64-0.32 1.34-0.32 1.25 4.353 1.7 6 1.7 2.43 0 6.313-0.456 5.98-1.7-0.52-1.94-0.208-1.71-0.98-2.3-1.09-0.654-2.452-1.167-3.6-1.6-0.15-0.557-0.04-0.97 0.1-1.5 0.235-0.25 0.5-0.36 0.72-0.6 0.69-0.884 0.78-2.424 0.78-3.5 0-1.586-1.43-2.8-3-2.8z"/></svg> | |||
Member
There was a problem hiding this comment.
Not convinced with that one. Too small. I prefer the old one :)
Member
There was a problem hiding this comment.
Yeah, this shouldn’t be changed in size. The form is visually not filled enough. :) Can you fix this @pixelipo, then it’s good to go.
only replace permission popupmenu
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Signed-off-by: Jan-Christoph Borchardt <hey@jancborchardt.net>
Add app content list
pixelipo
added
2. developing
…-permissions Add support for files with no permissions
Signed-off-by: Marin Treselj <marin@pixelipo.com>
pixelipo
added
3. to review
Contributor
Author
|
Ok @skjnldsv @jancborchardt - now that icon fills more space. I didn't revert the old icon since it wasn't using the same "figure" as the other "personal" icons. I've also updated all the other user-related icons to the same "figure" shape: Ready to review and merge :) |
Member
There are conflicts :/ |
Signed-off-by: Marin Treselj <marin@pixelipo.com>
Signed-off-by: Marin Treselj <marin@pixelipo.com>
Contributor
Author
|
Screwed up with rebase, please go here: #7231 |
MorrisJobke
added a commit
that referenced
this pull request
Nov 20, 2017
Re-optimize and clean up settings, social and logo icons #7209
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've discovered a whole set of icons in settings app that needed to be fixed (mostly I just replaced them with already optimized icons found in core/img/* folders).
I've also fixed social icons as well as logo and favicon SVGs. Those last ones are quite critical, so test those carefully.
@nextcloud/designers
(finally) Fixes #4076