Check if realpath() returns false #7822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
requested review from
ChristophWurst,
icewind1991,
nickvergessen and
rullzer
MorrisJobke
commented
Jan 12, 2018
| protected function findMigrations() { | ||
| $directory = realpath($this->migrationsPath); | ||
| if (!file_exists($directory) || !is_dir($directory)) { | ||
| if ($directory === false || !file_exists($directory) || !is_dir($directory)) { |
Member
Author
There was a problem hiding this comment.
I'm unsure if we should drop then the file_exists() call or if we want to have this sanity check still available.
Member
There was a problem hiding this comment.
Just leave it. Doesn't hurt to check.
nickvergessen
approved these changes
Jan 12, 2018
ChristophWurst
approved these changes
Jan 12, 2018
MorrisJobke
added
4. to release
icewind1991
approved these changes
Jan 12, 2018
realpath() returns false in case the directory does not exist. Found it while preparing strict_typing for PHP7+. Signed-off-by: Morris Jobke <hey@morrisjobke.de>
rullzer
force-pushed
the
check-if-realpath-returns-false
branch
from
ee3469e to
1efde41
Compare
Codecov Report
@@ Coverage Diff @@
## master #7822 +/- ##
=============================================
- Coverage 51.23% 34.75% -16.48%
+ Complexity 24973 24972 -1
=============================================
Files 1607 1607
Lines 95008 95008
Branches 1376 1376
=============================================
- Hits 48674 33019 -15655
- Misses 46334 61989 +15655
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
realpath() returns false in case the directory does not exist. Found it while preparing strict_typing for PHP7+. (#7392)