Strict typing tests

[MorrisJobke]

• first commit is only cleanup

[MorrisJobke]

@nickvergessen @rullzer I would say, that we should first get this in and then have followup PRs that add the strict typing to subtrees of our code.

[MorrisJobke]

Or should we already add lib/ already in this PR?

[nickvergessen]

Do we need to add it to each file?

[MorrisJobke]

Do we need to add it to each file?

Yes.

[nickvergessen]

I shall run my other script than to update the php testing versions in travis.yml for all apps on master I guess 🙊

[MorrisJobke]

Do we need to add it to each file?

There is a PHPStorm inspection for this: https://stackoverflow.com/a/43281565/520507

[nickvergessen]

I shall run my other script than to update the php testing versions in travis.yml for all apps on master I guess 🙊

Added here: #7808 (comment)

[codecov]

Codecov Report

Merging #7392 into master will decrease coverage by 45.44%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #7392       +/-   ##
============================================
- Coverage     52.07%   6.63%   -45.45%     
+ Complexity    25984   25347      -637     
============================================
  Files          1651    1607       -44     
  Lines         95983   95315      -668     
  Branches       1290    1394      +104     
============================================
- Hits          49983    6324    -43659     
- Misses        46000   88991    +42991

Impacted Files	Coverage Δ	Complexity Δ
lib/private/DB/MDB2SchemaManager.php	0% <ø> (-77.97%)	17 <0> (ø)
lib/private/DB/AdapterMySQL.php	0% <ø> (ø)	6 <0> (ø)	⬇️
...b/private/AppFramework/Utility/SimpleContainer.php	26.78% <ø> (-69.65%)	23 <0> (ø)
lib/private/DB/PostgreSqlMigrator.php	0% <ø> (ø)	6 <0> (ø)	⬇️
lib/private/Files/Node/Node.php	0% <ø> (-82.27%)	62 <0> (-3)
...ivate/Files/ObjectStore/HomeObjectStoreStorage.php	0% <ø> (ø)	7 <0> (ø)	⬇️
...curity/Exceptions/StrictCookieMissingException.php	0% <ø> (-100%)	1 <0> (ø)
lib/private/Files/SimpleFS/SimpleFolder.php	0% <ø> (-100%)	11 <0> (ø)
lib/private/Comments/Manager.php	0% <ø> (-96.25%)	80 <0> (-10)
lib/private/Files/Cache/Storage.php	0% <ø> (-63.08%)	23 <0> (ø)
... and 1370 more

[MorrisJobke]

Nothing for 14 it seems -> moved to 15

It's an ongoing improvement ;)