Make lib/autoloader.php strictly typed and p… #8334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This obsoletes the versioncheck partly... |
nickvergessen
previously requested changes
Feb 13, 2018
lib/versioncheck.php
Outdated
| @@ -1,4 +1,5 @@ | |||
| <?php | |||
| declare(strict_types=1); | |||
Member
Author
There was a problem hiding this comment.
A right .... didn't thought about it, but it doesn't make sense.
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
MorrisJobke
force-pushed
the
lib-strict-typing
branch
from
e23be54 to
5819e5e
Compare
MorrisJobke
changed the title
Codecov Report
@@ Coverage Diff @@
## master #8334 +/- ##
============================================
+ Coverage 51.69% 51.75% +0.06%
Complexity 25386 25386
============================================
Files 1599 1599
Lines 95109 95109
Branches 1376 1376
============================================
+ Hits 49162 49228 +66
+ Misses 45947 45881 -66
|
nickvergessen
approved these changes
Feb 14, 2018
rullzer
approved these changes
Feb 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…roperly type hinted
See also #7392