Made the cache factory strict #7901
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rullzer
requested review from
ChristophWurst,
MorrisJobke,
icewind1991,
juliusknorr and
nickvergessen
lib/private/Memcache/Factory.php
Outdated
| namespace OC\Memcache; | ||
|
|
||
| use OCP\ICache; | ||
| use \OCP\ICacheFactory; |
Member
There was a problem hiding this comment.
I'd prefer consistency here 😉
Member
Author
There was a problem hiding this comment.
fair enough... I gues one was hand writen and the other a phpstorm import ;)
rullzer
force-pushed
the
strict_cache_factory
branch
from
faf3f86 to
3197209
Compare
juliusknorr
approved these changes
Jan 16, 2018
ChristophWurst
approved these changes
Jan 16, 2018
Member
|
ref #7392 |
Member
|
Unit tests fail |
* Return types * Typehints * made strict * fix tests Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
strict_cache_factory
branch
from
3197209 to
c5fcfb0
Compare
Codecov Report
@@ Coverage Diff @@
## master #7901 +/- ##
============================================
- Coverage 51.24% 51.24% -0.01%
Complexity 24930 24930
============================================
Files 1604 1604
Lines 94988 94988
Branches 1376 1376
============================================
- Hits 48674 48673 -1
- Misses 46314 46315 +1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl