Make the URLGenerator strict #7853
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophWurst
approved these changes
Jan 14, 2018
MorrisJobke
previously requested changes
Jan 14, 2018
Member
MorrisJobke
left a comment
MorrisJobke
left a comment
There was a problem hiding this comment.
See tests - there are a lot failing (and fix the position of the strict types statement in the same step)
MorrisJobke
added
2. developing
* Add scalar argument types * Add return types * Make strict * General phpstorm cleanup Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
rullzer
force-pushed
the
strict_urlgenerator
branch
from
f2af37d to
a3b33be
Compare
Codecov Report
@@ Coverage Diff @@
## master #7853 +/- ##
=========================================
Coverage ? 34.74%
Complexity ? 24956
=========================================
Files ? 1607
Lines ? 95045
Branches ? 1376
=========================================
Hits ? 33021
Misses ? 62024
Partials ? 0
|
MorrisJobke
added
3. to review
juliusknorr
approved these changes
Jan 15, 2018
juliusknorr
added
4. to release
Member
|
ref (#7392) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Roeland Jago Douma roeland@famdouma.nl