Make Update notficiations strict and fix all inspections #7930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joas Schilling <coding@schilljs.com>
rullzer
reviewed
Jan 18, 2018
| $result['updateVersion'] = $data['versionstring']; | ||
| $result['updaterEnabled'] = $data['autoupdater'] === '1'; | ||
| if(substr($data['web'], 0, 8) === 'https://') { | ||
| if (strpos($data['web'], 'https://') === 0) { |
rullzer
reviewed
Jan 18, 2018
| $result = []; | ||
|
|
||
| if(isset($data['version']) && $data['version'] !== '' && $data['version'] !== []) { | ||
| if (isset($data['version']) && $data['version'] !== '' && $data['version'] !== []) { |
Codecov Report
@@ Coverage Diff @@
## master #7930 +/- ##
============================================
- Coverage 51.23% 51.22% -0.01%
- Complexity 24927 24928 +1
============================================
Files 1605 1605
Lines 94988 94994 +6
Branches 1376 1376
============================================
Hits 48664 48664
- Misses 46324 46330 +6
|
MorrisJobke
approved these changes
Jan 18, 2018
Member
|
ref (#7392) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Joas Schilling coding@schilljs.com