Ext storage error warning fix #8511
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
added
3. to review
skjnldsv
requested review from
MorrisJobke,
icewind1991,
juliusknorr and
rullzer
| <div class="icon-external"></div> | ||
| <h2><?php p($l->t('No external storage configured')); ?></h2> | ||
| <p><a href="<?php p(link_to('', 'index.php/settings/personal#files_external' )); ?>"><?php p($l->t('You can add external storages in the personal settings')); ?></a></p> | ||
| <p><a href="<?php p(link_to('', 'index.php/settings/admin/externalstorages' )); ?>"><?php p($l->t('You can add external storages in the personal settings')); ?></a></p> |
There was a problem hiding this comment.
The message here doesn't make much sense. It is shown, for personal external storage settings and if the administrator disabled the possibility to configure external storages in the personal settings there is nothing users can do about that. Also the link to admin/externalstorages only makes sense for admins.
There was a problem hiding this comment.
Maybe it should be something like: "You cannot configure external storages, since it has been disabled by the administrator"
There was a problem hiding this comment.
@juliushaertl It's not only about disabled by the admin, if you're the admin but you did not set up one at the moment, the page is still empty :)
"No external storage configured or you don't have the permission to configure them"
There was a problem hiding this comment.
Fine by me, better than referring to personal settings when you are on personal settings 😉
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
Codecov Report
@@ Coverage Diff @@
## master #8511 +/- ##
============================================
- Coverage 53.49% 51.81% -1.69%
- Complexity 24076 25375 +1299
============================================
Files 1443 1601 +158
Lines 80512 95041 +14529
Branches 0 1377 +1377
============================================
+ Hits 43067 49241 +6174
- Misses 37445 45800 +8355
|
skjnldsv
dismissed
juliusknorr’s stale review
Edited. Please update review :)
|
backport in #8561 |
Fix #8363