Skip to content

Conversation

@MorrisJobke
Copy link
Member

Found while reviewing #8511

Just go to http://example.org/settings/admin/externalstorages as normal user and check the error message

bildschirmfoto 2018-02-26 um 15 32 48

This text is now properly localised.

@MorrisJobke MorrisJobke added 3. to review Waiting for reviews papercut Annoying recurring UX issue with possibly simple fix. labels Feb 26, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Feb 26, 2018
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@juliusknorr
Copy link
Member

Tests are failing 😉

@MorrisJobke MorrisJobke force-pushed the translate-permission-error-page branch from d678487 to e298927 Compare February 26, 2018 15:27
@codecov
Copy link

codecov bot commented Feb 26, 2018

Codecov Report

Merging #8541 into master will decrease coverage by 45.19%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #8541      +/-   ##
===========================================
- Coverage     51.82%   6.62%   -45.2%     
  Complexity    25379   25379              
===========================================
  Files          1601    1601              
  Lines         95065   95070       +5     
  Branches       1379    1379              
===========================================
- Hits          49265    6297   -42968     
- Misses        45800   88773   +42973
Impacted Files Coverage Δ Complexity Δ
...ddleware/Security/Exceptions/NotAdminException.php 0% <0%> (-100%) 1 <1> (ø)
settings/Middleware/SubadminMiddleware.php 0% <0%> (-92.86%) 6 <0> (ø)
...amework/Middleware/Security/SecurityMiddleware.php 0% <0%> (-78.05%) 26 <0> (ø)
...e/AppFramework/DependencyInjection/DIContainer.php 0% <0%> (-82.73%) 54 <0> (ø)
apps/comments/lib/JSSettingsHelper.php 0% <0%> (-100%) 2% <0%> (ø)
apps/files_trashbin/lib/AppInfo/Application.php 0% <0%> (-100%) 2% <0%> (ø)
core/Command/TwoFactorAuth/Enable.php 0% <0%> (-100%) 4% <0%> (ø)
apps/dav/lib/CalDAV/Activity/Filter/Calendar.php 0% <0%> (-100%) 7% <0%> (ø)
lib/private/Comments/ManagerFactory.php 0% <0%> (-100%) 2% <0%> (ø)
settings/Activity/SecuritySetting.php 0% <0%> (-100%) 8% <0%> (ø)
... and 864 more

@MorrisJobke
Copy link
Member Author

Tests are failing 😉

🙈 Too stupid to fix the unit tests properly (added the new dependency 3 lines too low xD)

@rullzer rullzer added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 26, 2018
@MorrisJobke MorrisJobke force-pushed the translate-permission-error-page branch from e298927 to 537fbdc Compare February 26, 2018 15:30
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke force-pushed the translate-permission-error-page branch from 537fbdc to cf35c4b Compare February 26, 2018 16:00
@MorrisJobke MorrisJobke merged commit a60d7a8 into master Feb 26, 2018
@MorrisJobke MorrisJobke deleted the translate-permission-error-page branch February 26, 2018 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish papercut Annoying recurring UX issue with possibly simple fix.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants