-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Provide translated error message for permission error #8541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
approved these changes
Feb 26, 2018
Member
skjnldsv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good
rullzer
approved these changes
Feb 26, 2018
juliusknorr
approved these changes
Feb 26, 2018
Member
|
Tests are failing 😉 |
d678487 to
e298927
Compare
Codecov Report
@@ Coverage Diff @@
## master #8541 +/- ##
===========================================
- Coverage 51.82% 6.62% -45.2%
Complexity 25379 25379
===========================================
Files 1601 1601
Lines 95065 95070 +5
Branches 1379 1379
===========================================
- Hits 49265 6297 -42968
- Misses 45800 88773 +42973
|
Member
Author
🙈 Too stupid to fix the unit tests properly (added the new dependency 3 lines too low xD) |
e298927 to
537fbdc
Compare
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
537fbdc to
cf35c4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
4. to release
Ready to be released and/or waiting for tests to finish
papercut
Annoying recurring UX issue with possibly simple fix.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found while reviewing #8511
Just go to http://example.org/settings/admin/externalstorages as normal user and check the error message
This text is now properly localised.