-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Fixed email form on new user #8587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
| autocomplete="off" autocapitalize="none" autocorrect="off" /> | ||
| </td> | ||
| <td class="password"> | ||
| <input id="newuserpassword" type="password" required |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not required, already handled by server and generated if email is valid
server/settings/Controller/UsersController.php
Lines 425 to 439 in 0cfdf47
| if ($password === '') { | |
| if ($email === '') { | |
| return new DataResponse( | |
| [ | |
| 'message' => (string)$this->l10n->t('To send a password link to the user an email address is required.') | |
| ], | |
| Http::STATUS_UNPROCESSABLE_ENTITY | |
| ); | |
| } | |
| $password = $this->secureRandom->generate(30); | |
| // Make sure we pass the password_policy | |
| $password .= $this->secureRandom->generate(2, '$!.,;:-~+*[]{}()'); | |
| $generatePasswordResetToken = true; | |
| } |
rullzer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
makes sense
|
Failure unrelated |
Fix bug where the email in a user creation was always sent blank to the server.
Also fixes #6468