Skip to content

Ellipsize long values in the user management #8605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rullzer merged 1 commit into from
Mar 1, 2018
Merged

Ellipsize long values in the user management #8605

rullzer merged 1 commit into from
Mar 1, 2018

Conversation

@juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Mar 1, 2018 •
edited
Loading

This will properly limit the size of the text for username, displayname and email.

Found when reviewing #8587
Before:
peek 2018-03-01 17-04

After:
peek 2018-03-01 16-59

@juliusknorr juliusknorr added bug 3. to review Waiting for reviews papercut Annoying recurring UX issue with possibly simple fix. feature: users and groups labels Mar 1, 2018
@juliusknorr juliusknorr added this to the Nextcloud 14 milestone Mar 1, 2018
skjnldsv
skjnldsv approved these changes Mar 1, 2018
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fair!

rullzer
rullzer approved these changes Mar 1, 2018
View reviewed changes
Copy link
Member

@rullzer rullzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@juliusknorr @rullzer
Ellipsize long values in the user management
c820ee8 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@rullzer rullzer force-pushed the user-page-ellipsize branch from c9ca0bf to c820ee8 Compare March 1, 2018 19:17
@codecov
Copy link

codecov bot commented Mar 1, 2018 •
edited
Loading

Codecov Report

Merging #8605 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8605      +/-   ##
============================================
+ Coverage     51.86%   51.89%   +0.02%     
- Complexity    25418    25478      +60     
============================================
  Files          1609     1609              
  Lines         95329    95408      +79     
  Branches       1378     1378              
============================================
+ Hits          49446    49512      +66     
- Misses        45883    45896      +13
Impacted Files Coverage Δ Complexity Δ
lib/private/Files/Storage/Common.php 56.58% <0%> (-12.63%) 207% <0%> (+60%)
lib/private/Files/Cache/Propagator.php 94.93% <0%> (-1.27%) 16% <0%> (ø)
lib/private/Files/ObjectStore/SwiftFactory.php 56.32% <0%> (+56.32%) 35% <0%> (ø) ⬇️
lib/private/Files/ObjectStore/Swift.php 75% <0%> (+75%) 8% <0%> (ø) ⬇️

@skjnldsv skjnldsv added the 4. to release Ready to be released and/or waiting for tests to finish label Mar 1, 2018
@rullzer rullzer merged commit e8f9257 into master Mar 1, 2018
@rullzer rullzer deleted the user-page-ellipsize branch March 1, 2018 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@MorrisJobke MorrisJobke Awaiting requested review from MorrisJobke

@pixelipo pixelipo Awaiting requested review from pixelipo

Assignees

No one assigned

Labels

3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish bug feature: users and groups papercut Annoying recurring UX issue with possibly simple fix.

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@juliusknorr @rullzer @skjnldsv