Skip to content

Fixed date/time picker on IE11 #8650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Mar 5, 2018
Merged

Fixed date/time picker on IE11 #8650

MorrisJobke merged 1 commit into from
Mar 5, 2018

Conversation

@skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 5, 2018 •
edited
Loading

Fix #8484 @nextcloud/designers @jpimlott

Before After
virtualbox_ie11 - win7_01_03_2018_21_36_03 virtualbox_ie11 - win7_01_03_2018_21_36_05
virtualbox_ie11 - win7_01_03_2018_21_42_56 virtualbox_ie11 - win7_01_03_2018_21_35_52

@skjnldsv
Fixed date/time picker on IE11
31c7fcd 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews medium regression labels Mar 5, 2018
@skjnldsv skjnldsv added this to the Nextcloud 14 milestone Mar 5, 2018
@skjnldsv skjnldsv self-assigned this Mar 5, 2018
@pixelipo pixelipo removed their request for review March 5, 2018 11:06
@pixelipo
Copy link
Contributor

pixelipo commented Mar 5, 2018

Sorry @skjnldsv - I'm not able to test on IE11. Code looks ok, though

@codecov
Copy link

codecov bot commented Mar 5, 2018 •
edited
Loading

Codecov Report

Merging #8650 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #8650      +/-   ##
============================================
- Coverage     51.87%   51.87%   -0.01%     
  Complexity    25351    25351              
============================================
  Files          1606     1606              
  Lines         95066    95066              
  Branches       1378     1378              
============================================
- Hits          49316    49315       -1     
- Misses        45750    45751       +1
Impacted Files Coverage Δ Complexity Δ
lib/private/Security/CertificateManager.php 91% <0%> (-3%) 39% <0%> (ø)
apps/files_trashbin/lib/Trashbin.php 72.46% <0%> (-0.25%) 136% <0%> (ø)
lib/private/Server.php 83.1% <0%> (+0.09%) 282% <0%> (ø) ⬇️
lib/private/Files/ObjectStore/SwiftFactory.php 56.32% <0%> (+2.29%) 35% <0%> (ø) ⬇️

MorrisJobke
MorrisJobke approved these changes Mar 5, 2018
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works 👍

@MorrisJobke MorrisJobke merged commit f72e9ae into master Mar 5, 2018
@MorrisJobke MorrisJobke deleted the fix-ie11-datepicker-display branch March 5, 2018 15:38
@MorrisJobke
Copy link
Member

MorrisJobke commented Mar 5, 2018

@skjnldsv Could you open a Backport PR?

@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 5, 2018

Of course!

@skjnldsv skjnldsv mentioned this pull request Mar 5, 2018
Merged
@skjnldsv
Copy link
Member Author

skjnldsv commented Mar 5, 2018 •
edited
Loading

Backport in #8663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MorrisJobke MorrisJobke MorrisJobke approved these changes

@rullzer rullzer Awaiting requested review from rullzer

@jancborchardt jancborchardt Awaiting requested review from jancborchardt

@juliusknorr juliusknorr Awaiting requested review from juliusknorr

@danxuliu danxuliu Awaiting requested review from danxuliu

Assignees

@skjnldsv skjnldsv

Labels

3. to review Waiting for reviews bug design Design, UI, UX, etc. medium regression

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

5 participants

@skjnldsv @pixelipo @MorrisJobke @rullzer