Strict settings

[rullzer]

For #8375

[codecov]

Codecov Report

Merging #8743 into master will decrease coverage by 20.35%.
The diff coverage is 4.25%.

@@              Coverage Diff              @@
##             master    #8743       +/-   ##
=============================================
- Coverage     51.79%   31.44%   -20.36%     
  Complexity    25377    25377               
=============================================
  Files          1608     1608               
  Lines         95173    95172        -1     
  Branches       1377     1377               
=============================================
- Hits          49297    29927    -19370     
- Misses        45876    65245    +19369

Impacted Files	Coverage Δ	Complexity Δ
settings/Controller/UsersController.php	0% <0%> (-68.9%)	121 <114> (ø)
settings/Controller/ChangePasswordController.php	16.36% <40%> (ø)	26 <26> (ø)	⬇️
lib/private/TagManager.php	0% <0%> (-100%)	4% <0%> (ø)
...public/AppFramework/OCS/OCSBadRequestException.php	0% <0%> (-100%)	1% <0%> (ø)
apps/user_ldap/lib/Migration/UUIDFixGroup.php	0% <0%> (-100%)	1% <0%> (ø)
...ivate/Files/Cache/Wrapper/CachePermissionsMask.php	0% <0%> (-100%)	3% <0%> (ø)
apps/user_ldap/lib/LDAPProviderFactory.php	0% <0%> (-100%)	2% <0%> (ø)
apps/files_trashbin/lib/AppInfo/Application.php	0% <0%> (-100%)	2% <0%> (ø)
apps/files_trashbin/lib/Hooks.php	0% <0%> (-100%)	3% <0%> (ø)
lib/private/Accounts/Hooks.php	0% <0%> (-100%)	14% <0%> (ø)
... and 374 more

[nickvergessen]

just adding both here should work and we can still only request IGroupManager ?
Or why is it needed?

[rullzer]

Else it can't resolve

server/settings/Controller/ChangePasswordController.php

Line 174 in 0eebff1

$this->groupManager->getSubAdmin()->isUserAccessible($currentUser, $targetUser))

and phan keeps complaining.

I guess for Settings and Core it is fine to inject the non public ones. As we don't always want to expose everything.

[MorrisJobke]

Tested and still works 👍