Make phan config more strict #8375
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorrisJobke
force-pushed
the
make-phan-config-more-strict
branch
2 times, most recently
from
3fbc39a to
9f01041
Compare
Member
Author
|
Rebased and resolved quite some stuff to make it a bit easier to dive through them: Before: After: |
MorrisJobke
force-pushed
the
make-phan-config-more-strict
branch
3 times, most recently
from
f0d23ee to
5ef467b
Compare
Member
|
Wow seems we did good :) |
Member
Author
|
2018-03-09: 1814 warnings to go xD |
Merged
MorrisJobke
force-pushed
the
make-phan-config-more-strict
branch
from
5ef467b to
6f03948
Compare
This was referenced Mar 12, 2018
MorrisJobke
added
2. developing
This was referenced Mar 12, 2018
MorrisJobke
force-pushed
the
make-phan-config-more-strict
branch
3 times, most recently
from
86e20dc to
d8b659b
Compare
This was referenced Mar 12, 2018
MorrisJobke
force-pushed
the
make-phan-config-more-strict
branch
from
d8b659b to
63490b0
Compare
MorrisJobke
force-pushed
the
make-phan-config-more-strict
branch
from
63490b0 to
365b488
Compare
MorrisJobke
force-pushed
the
make-phan-config-more-strict
branch
from
365b488 to
3eb36b3
Compare
Codecov Report
@@ Coverage Diff @@
## master #8375 +/- ##
=========================================
Coverage ? 51.93%
Complexity ? 25388
=========================================
Files ? 1608
Lines ? 95440
Branches ? 1394
=========================================
Hits ? 49564
Misses ? 45876
Partials ? 0 |
MorrisJobke
force-pushed
the
make-phan-config-more-strict
branch
from
3eb36b3 to
9649aa3
Compare
MorrisJobke
force-pushed
the
make-phan-config-more-strict
branch
from
9649aa3 to
58a348b
Compare
MorrisJobke
force-pushed
the
make-phan-config-more-strict
branch
2 times, most recently
from
c251ead to
e25e963
Compare
Merged
MorrisJobke
force-pushed
the
make-phan-config-more-strict
branch
from
e25e963 to
88487c6
Compare
This was referenced Apr 26, 2018
MorrisJobke
commented
Apr 26, 2018
build/.phan/config.php
Outdated
| // critical issues is a good place to start on a big | ||
| // sloppy mature code base. | ||
| 'minimum_severity' => \Phan\Issue::SEVERITY_CRITICAL, | ||
| 'minimum_severity' => \Phan\Issue::SEVERITY_NORMAL, |
Member
Author
There was a problem hiding this comment.
Okay this causes ~1200 warnings -> let's do this later
MorrisJobke
force-pushed
the
make-phan-config-more-strict
branch
from
88487c6 to
068097b
Compare
* fix ocs/ and remote.php * ignore some more templates of apps Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
MorrisJobke
force-pushed
the
make-phan-config-more-strict
branch
from
068097b to
99e32e1
Compare
Member
Author
|
Not the way to go -> closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reminder for myself to take this and get it step by step in.
cc @rullzer