Skip to content

Remove old code to be compatible with Nextcloud 9 and before #8781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Mar 13, 2018
Merged

Remove old code to be compatible with Nextcloud 9 and before #8781

MorrisJobke merged 1 commit into from
Mar 13, 2018

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Mar 12, 2018 •
edited
Loading

Even 10 is already EoL

cc @nextcloud/sharing @nickvergessen @blizzz

Ref #8375

@MorrisJobke
Remove old code to be compatible with Nextcloud 9 and before
4cbcf6f 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Mar 12, 2018
ChristophWurst
ChristophWurst approved these changes Mar 12, 2018
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me 🔥

@rullzer
Copy link
Member

rullzer commented Mar 13, 2018

Ah well. In principal I'm fine. But this does mean that you might not be able to mount shares of other people. You can't control their instance.

@schiessle what is your take on this.

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 13, 2018

Ah well. In principal I'm fine. But this does mean that you might not be able to mount shares of other people. You can't control their instance.

Sure, but at some point we need to drop support for old instances. And let's hope that there are no instances with 9 out there that want to federate with 14 ...

@MorrisJobke
Copy link
Member Author

MorrisJobke commented Mar 13, 2018

Sure, but at some point we need to drop support for old instances. And let's hope that there are no instances with 9 out there that want to federate with 14 ...

In other words: the code on those instances might have security issues, that we only fixed in 10+ because of the EoL state.

@MorrisJobke MorrisJobke merged commit 58599e0 into master Mar 13, 2018
@MorrisJobke MorrisJobke deleted the cleanup-old-federation-code branch March 13, 2018 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@MariusBluem MariusBluem MariusBluem approved these changes

@nickvergessen nickvergessen Awaiting requested review from nickvergessen

@schiessle schiessle Awaiting requested review from schiessle

@blizzz blizzz Awaiting requested review from blizzz

Assignees

No one assigned

Labels

3. to review Waiting for reviews technical debt

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

5 participants

@MorrisJobke @rullzer @ChristophWurst @MariusBluem