Less deprecated calls to OCP\Util::writeLog #9255
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // FIXME this should be a method in the user management instead | ||
| \OCP\Util::writeLog('files_sharing', 'shareWith before, ' . $shareWith, \OCP\Util::DEBUG); | ||
| $logger = \OC::$server->getLogger(); |
Member
Author
There was a problem hiding this comment.
This is specified in the ->debug() call
Member
There was a problem hiding this comment.
what? I mean require ILogger in the constructor instead of using global \OC::$server here
Member
Author
There was a problem hiding this comment.
Sure would make sense of course 🙈
nickvergessen
approved these changes
Apr 20, 2018
rullzer
approved these changes
Apr 20, 2018
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
rullzer
force-pushed
the
less-deprecated-calls
branch
from
b38b057 to
dd34cb7
Compare
Codecov Report
@@ Coverage Diff @@
## master #9255 +/- ##
============================================
+ Coverage 51.9% 51.95% +0.04%
- Complexity 25365 25375 +10
============================================
Files 1607 1607
Lines 95330 95393 +63
Branches 1394 1394
============================================
+ Hits 49482 49557 +75
+ Misses 45848 45836 -12
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #8375