Skip to content

Fix DI for federated file sharing controller #9269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MorrisJobke merged 1 commit into from
Apr 23, 2018
Merged

Fix DI for federated file sharing controller #9269

MorrisJobke merged 1 commit into from
Apr 23, 2018

Conversation

@MorrisJobke
Copy link
Member

@MorrisJobke MorrisJobke commented Apr 23, 2018

For #9255

@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Apr 23, 2018
@MorrisJobke MorrisJobke mentioned this pull request Apr 23, 2018
Merged
nickvergessen
nickvergessen reviewed Apr 23, 2018
View reviewed changes
apps/federatedfilesharing/tests/Controller/RequestHandlerControllerTest.php Outdated

$this->cloudIdManager = new CloudIdManager();

$this->logger = $this->getMockBuilder(ILogger::class)->getMock();
Copy link
Member

@nickvergessen nickvergessen Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createMock for extra points

Copy link
Member Author

@MorrisJobke MorrisJobke Apr 23, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want them! 💯

@MorrisJobke MorrisJobke force-pushed the fix-DI-for-federeatedfilesharing-controller branch from 8013c04 to cb71d52 Compare April 23, 2018 09:10
@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 23, 2018
@MorrisJobke
Fix DI for federated file sharing controller
093cd01 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke force-pushed the fix-DI-for-federeatedfilesharing-controller branch from cb71d52 to 093cd01 Compare April 23, 2018 11:49
@codecov
Copy link

codecov bot commented Apr 23, 2018

Codecov Report

Merging #9269 into master will decrease coverage by 20.42%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             master    #9269       +/-   ##
=============================================
- Coverage     51.95%   31.52%   -20.43%     
  Complexity    25375    25375               
=============================================
  Files          1607     1607               
  Lines         95393    95395        +2     
  Branches       1394     1394               
=============================================
- Hits          49559    30073    -19486     
- Misses        45834    65322    +19488
Impacted Files Coverage Δ Complexity Δ
...haring/lib/Controller/RequestHandlerController.php 0% <0%> (-30.48%) 82 <0> (ø)
...s/federatedfilesharing/lib/AppInfo/Application.php 0% <0%> (-64.82%) 5 <0> (ø)
apps/files_trashbin/lib/Hooks.php 0% <0%> (-100%) 3% <0%> (ø)
lib/private/Files/Cache/Wrapper/JailPropagator.php 0% <0%> (-100%) 1% <0%> (ø)
lib/public/Comments/CommentsEvent.php 0% <0%> (-100%) 3% <0%> (ø)
apps/user_ldap/lib/Migration/UUIDFixGroup.php 0% <0%> (-100%) 1% <0%> (ø)
apps/user_ldap/lib/Migration/UUIDFix.php 0% <0%> (-100%) 5% <0%> (ø)
apps/user_ldap/lib/Mapping/GroupMapping.php 0% <0%> (-100%) 1% <0%> (ø)
lib/public/Files/ForbiddenException.php 0% <0%> (-100%) 2% <0%> (ø)
apps/files_sharing/lib/External/MountProvider.php 0% <0%> (-100%) 4% <0%> (ø)
... and 370 more

@MorrisJobke MorrisJobke merged commit 6c6feea into master Apr 23, 2018
@MorrisJobke MorrisJobke deleted the fix-DI-for-federeatedfilesharing-controller branch April 23, 2018 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rullzer rullzer rullzer approved these changes

@nickvergessen nickvergessen nickvergessen approved these changes

@schiessle schiessle Awaiting requested review from schiessle

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt

Projects

None yet

Milestone

Nextcloud 14

Development

Successfully merging this pull request may close these issues.

4 participants

@MorrisJobke @rullzer @nickvergessen