Skip to content

Conversation

@MorrisJobke
Copy link
Member

Ref #8375

Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code makes sense

Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke force-pushed the properly-use-new-method-to-format-date branch from cb805f5 to 44289ff Compare March 12, 2018 14:16
@codecov
Copy link

codecov bot commented Mar 12, 2018

Codecov Report

Merging #8782 into master will decrease coverage by 20.49%.
The diff coverage is 0%.

@@             Coverage Diff              @@
##             master    #8782      +/-   ##
============================================
- Coverage     51.87%   31.37%   -20.5%     
+ Complexity    25380    25376       -4     
============================================
  Files          1608     1608              
  Lines         95157    95151       -6     
  Branches       1377     1377              
============================================
- Hits          49366    29858   -19508     
- Misses        45791    65293   +19502
Impacted Files Coverage Δ Complexity Δ
lib/private/legacy/util.php 25.74% <ø> (-33.04%) 240 <0> (-4)
settings/templates/settings/admin/server.php 0% <0%> (ø) 0 <0> (ø) ⬇️
lib/private/TagManager.php 0% <0%> (-100%) 4% <0%> (ø)
apps/user_ldap/lib/LDAPUtility.php 0% <0%> (-100%) 1% <0%> (ø)
...s/dav/lib/Connector/Sabre/Exception/FileLocked.php 0% <0%> (-100%) 3% <0%> (ø)
lib/private/Share20/Hooks.php 0% <0%> (-100%) 3% <0%> (ø)
lib/private/Files/Mount/CacheMountProvider.php 0% <0%> (-100%) 4% <0%> (ø)
lib/private/Accounts/Hooks.php 0% <0%> (-100%) 14% <0%> (ø)
...public/AppFramework/OCS/OCSBadRequestException.php 0% <0%> (-100%) 1% <0%> (ø)
...yBuilder/FunctionBuilder/SqliteFunctionBuilder.php 0% <0%> (-100%) 1% <0%> (ø)
... and 374 more

@MorrisJobke MorrisJobke merged commit 3df2fb7 into master Mar 12, 2018
@MorrisJobke MorrisJobke deleted the properly-use-new-method-to-format-date branch March 12, 2018 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants