Skip to content

Conversation

@MorrisJobke
Copy link
Member

Extracted from #8375

@MorrisJobke MorrisJobke added the 2. developing Work in progress label Apr 26, 2018
@MorrisJobke MorrisJobke added this to the Nextcloud 14 milestone Apr 26, 2018
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
@MorrisJobke MorrisJobke force-pushed the phan-normal-severity branch from 1ab33bd to b7bebab Compare April 26, 2018 13:05
@codecov
Copy link

codecov bot commented Apr 26, 2018

Codecov Report

Merging #9314 into master will decrease coverage by 45.18%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #9314       +/-   ##
============================================
- Coverage     51.93%   6.74%   -45.19%     
  Complexity    25388   25388               
============================================
  Files          1608    1608               
  Lines         95440   95440               
  Branches       1394    1394               
============================================
- Hits          49563    6437    -43126     
- Misses        45877   89003    +43126
Impacted Files Coverage Δ Complexity Δ
apps/comments/lib/JSSettingsHelper.php 0% <0%> (-100%) 2% <0%> (ø)
lib/private/Security/CSRF/CsrfToken.php 0% <0%> (-100%) 5% <0%> (ø)
apps/files/lib/Activity/Settings/FileChanged.php 0% <0%> (-100%) 8% <0%> (ø)
...curity/Exceptions/StrictCookieMissingException.php 0% <0%> (-100%) 1% <0%> (ø)
apps/user_ldap/lib/Mapping/UserMapping.php 0% <0%> (-100%) 1% <0%> (ø)
apps/user_ldap/lib/Migration/UUIDFixGroup.php 0% <0%> (-100%) 1% <0%> (ø)
apps/files/appinfo/app.php 0% <0%> (-100%) 0% <0%> (ø)
apps/encryption/lib/Users/Setup.php 0% <0%> (-100%) 6% <0%> (ø)
...yBuilder/FunctionBuilder/SqliteFunctionBuilder.php 0% <0%> (-100%) 1% <0%> (ø)
lib/private/Hooks/LegacyEmitter.php 0% <0%> (-100%) 1% <0%> (ø)
... and 866 more

@MorrisJobke
Copy link
Member Author

Okay this causes ~1200 warnings -> let's do this later

@MorrisJobke MorrisJobke deleted the phan-normal-severity branch April 26, 2018 13:29
@MorrisJobke MorrisJobke removed this from the Nextcloud 14 milestone Apr 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2. developing Work in progress

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants