[stable10] Files external settings polish #902
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Mar1u5, thanks for your PR! By analyzing the annotation information on this pull request, we identified @icewind1991, @Xenopathic and @jancborchardt to be potential reviewers |
Member
|
backport is incomplete because we lost at least two commits on the master branch, see #787 (comment) @icewind1991 please have a look. Thanks! |
Member
Author
|
As soon as these two commits (#906) are in master, i will add them to the backport 😉 |
Member
Author
|
MorrisJobke
added
2. developing
Member
Author
|
Backport is now complete 💪 Please review @schiessle @MorrisJobke @icewind1991 |
MorrisJobke
added
3. to review
Member
Then also change the label 😉 |
Member
|
Tested and works 👍 |
1 similar comment
|
Tested and works 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #787 and #906
cc @icewind1991 @LukasReschke @MorrisJobke @schiessle