Files external settings polish #906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@icewind1991, thanks for your PR! By analyzing the annotation information on this pull request, we identified @Xenopathic, @rnicoll and @nickvergessen to be potential reviewers |
Member
|
Thanks Robin, works great! 👍 |
Member
|
@Mar1u5 please make sure to pull this commits over to your backport once it was reviewed |
Member
|
👍 |
Member
|
As soon as these two commits are in |
Member
|
Tests do fail, @icewind1991 any idea? |
LukasReschke
added
2. developing
icewind1991
force-pushed
the
files_external-settings-polish-missing
branch
from
714f441 to
2332ed3
Compare
MorrisJobke
added
3. to review
Member
Author
|
tests all green |
Member
|
I will now add these commits to the |
GitHubUser4234
pushed a commit
to GitHubUser4234/server
that referenced
this pull request
Aug 30, 2016
…gs-polish-missing Files external settings polish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The missing commits from #787
cc @MorrisJobke @schiessle