Skip to content

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented Apr 10, 2018

@skjnldsv I guess we missed this during your improvements
@danxuliu maybe youknow of an easier fix for the integration tests.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added bug 3. to review Waiting for reviews labels Apr 10, 2018
@rullzer rullzer added this to the Nextcloud 14 milestone Apr 10, 2018
Copy link
Member

@danxuliu danxuliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov
Copy link

codecov bot commented Apr 10, 2018

Codecov Report

Merging #9136 into master will decrease coverage by 16.91%.
The diff coverage is 0%.

@@              Coverage Diff              @@
##             master    #9136       +/-   ##
=============================================
- Coverage     51.84%   34.92%   -16.92%     
  Complexity    25313    25313               
=============================================
  Files          1604     1604               
  Lines         95133    95133               
  Branches       1387     1387               
=============================================
- Hits          49324    33228    -16096     
- Misses        45809    61905    +16096
Impacted Files Coverage Δ Complexity Δ
apps/provisioning_api/lib/Controller/AUserData.php 0% <0%> (-61.85%) 14 <0> (ø)
apps/dav/lib/CalDAV/Activity/Setting/Calendar.php 0% <0%> (-100%) 8% <0%> (ø)
lib/private/Hooks/LegacyEmitter.php 0% <0%> (-100%) 1% <0%> (ø)
core/Command/Background/WebCron.php 0% <0%> (-100%) 1% <0%> (ø)
...ddleware/Security/Exceptions/NotAdminException.php 0% <0%> (-100%) 1% <0%> (ø)
lib/public/AppFramework/Http/JSONResponse.php 0% <0%> (-100%) 5% <0%> (ø)
apps/dav/lib/Files/Sharing/FilesDropPlugin.php 0% <0%> (-100%) 6% <0%> (ø)
apps/files/lib/Activity/Settings/FileChanged.php 0% <0%> (-100%) 8% <0%> (ø)
lib/private/BackgroundJob/QueuedJob.php 0% <0%> (-100%) 1% <0%> (ø)
settings/Activity/SecurityFilter.php 0% <0%> (-100%) 7% <0%> (ø)
... and 522 more

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙈

@MorrisJobke MorrisJobke added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 10, 2018
@MorrisJobke MorrisJobke merged commit a655401 into master Apr 11, 2018
@MorrisJobke MorrisJobke deleted the bugfix/noid/fix_provisioning_integrationtests branch April 11, 2018 00:11
@skjnldsv
Copy link
Member

🙈

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants