Return proper boolean user enabled state api #9168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
force-pushed
the
enabled-state-proper-return-and-tests-fixes
branch
from
1c6b197 to
9d8c045
Compare
Codecov Report
@@ Coverage Diff @@
## master #9168 +/- ##
========================================
Coverage 51.9% 51.9%
Complexity 25354 25354
========================================
Files 1606 1606
Lines 95301 95301
Branches 1394 1394
========================================
Hits 49465 49465
Misses 45836 45836
|
skjnldsv
force-pushed
the
enabled-state-proper-return-and-tests-fixes
branch
5 times, most recently
from
11be2c2 to
0822e8f
Compare
Member
Author
|
Intégration provisioning v1 now passes! :) |
skjnldsv
requested review from
MorrisJobke,
danxuliu,
nickvergessen and
rullzer
skjnldsv
force-pushed
the
enabled-state-proper-return-and-tests-fixes
branch
from
0822e8f to
8f6e446
Compare
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
skjnldsv
force-pushed
the
enabled-state-proper-return-and-tests-fixes
branch
from
8f6e446 to
3e5ea9b
Compare
nickvergessen
approved these changes
Apr 16, 2018
MorrisJobke
reviewed
Apr 16, 2018
|
|
||
| $this->response = $client->get($fullUrl, $options); | ||
| PHPUnit_Framework_Assert::assertEquals("true", simplexml_load_string($this->response->getBody())->data[0]->enabled); | ||
| // boolean to string is integer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #9111 and #9136
Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com