Skip to content

Move versions webui to DAV #9450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rullzer wants to merge 4 commits into from
Closed

Move versions webui to DAV #9450

rullzer wants to merge 4 commits into from

Conversation

@rullzer
Copy link
Member

@rullzer rullzer commented May 10, 2018 •
edited
Loading

Now that we have a fancy DAV endpoint we better use it!

Fixes #9385

  • Use the backbone webdav code.
  • Fetch all versions at once

Todo:

  • Restore via DAV
  • Download via DAV
    • Proper filename when downloading via DAV
  • Fix tests

@rullzer
Get version list via DAV
90416ca 
Now that we have a fancy DAV endpoint we better use it!

* Use the backbone webdav code.
* Fetch all versions at once

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer rullzer added this to the Nextcloud 14 milestone May 10, 2018
@rullzer rullzer changed the title Get version list via DAV Move versions webui to DAV May 10, 2018
rullzer added 3 commits May 11, 2018 14:09
@rullzer
Handle download via DAV
351eb78 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Restore via DAV
c387b49 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Kill off old endpoints
7bc03a8 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@codecov
Copy link

codecov bot commented May 11, 2018

Codecov Report

Merging #9450 into master will decrease coverage by 0.58%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #9450      +/-   ##
============================================
- Coverage     51.61%   51.03%   -0.59%     
  Complexity    25694    25694              
============================================
  Files          1638     1571      -67     
  Lines         96318    88376    -7942     
  Branches       1393        0    -1393     
============================================
- Hits          49712    45099    -4613     
+ Misses        46606    43277    -3329
Impacted Files Coverage Δ Complexity Δ
apps/files_trashbin/lib/Expiration.php 90.32% <0%> (-1.62%) 29% <0%> (ø)
core/js/mimetype.js
apps/comments/js/commentsummarymodel.js
core/js/multiselect.js
core/vendor/marked/marked.min.js
core/js/sharedialogview.js
apps/files_sharing/js/files_drop.js
apps/comments/js/commentsmodifymenu.js
apps/comments/js/filesplugin.js
...mments/js/vendor/At.js/dist/js/jquery.atwho.min.js
... and 55 more

@MorrisJobke MorrisJobke added the stale Ticket or PR with no recent activity label Jun 19, 2018
@rullzer rullzer modified the milestones: Nextcloud 14, Nextcloud 15 Jul 11, 2018
@rullzer rullzer mentioned this pull request Oct 12, 2018
Merged
@rullzer
Copy link
Member Author

rullzer commented Oct 12, 2018

See #11778

@rullzer rullzer closed this Oct 12, 2018
@nextcloud-bot nextcloud-bot removed the stale Ticket or PR with no recent activity label Oct 12, 2018
@rullzer rullzer deleted the feature/9385/version_webui_to_dav branch October 12, 2018 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@danxuliu danxuliu

Labels

2. developing Work in progress enhancement feature: dav feature: versions technical debt

Projects

None yet

Milestone

Nextcloud 15

Development

Successfully merging this pull request may close these issues.

5 participants

@rullzer @MorrisJobke @nextcloud-bot @danxuliu